fix(desktop): terminal page links follow the URL link rules

apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx

@@ -14,21 +14,17 @@ import {
 	useState,
 	useSyncExternalStore,
 } from "react";
-import { env } from "renderer/env.renderer";
 import { useTerminalAppearance } from "renderer/hooks/useTerminalAppearance";
-import { useV2UserPreferences } from "renderer/hooks/useV2UserPreferences";
 import { useHotkey } from "renderer/hotkeys";
 import {
 	actionLabel,
 	type FolderClickPolicy,
 	folderIntentLabel,
-	type LinkAction,
 	LinkHoverHint,
 	useTerminalFilePolicy,
 	useTerminalFolderPolicy,
 	useTerminalUrlPolicy,
 } from "renderer/lib/clickPolicy";
-import { parseSupersetPageUrl } from "renderer/lib/parseSupersetPageUrl";
 import {
 	type ConnectionState,
 	terminalRuntimeRegistry,
@@ -85,7 +81,6 @@ export function TerminalPane({
 	const filePolicy = useTerminalFilePolicy();
 	const urlPolicy = useTerminalUrlPolicy();
 	const folderPolicy = useTerminalFolderPolicy();
-	const { preferences } = useV2UserPreferences();
 	const {
 		hoveredLink,
 		liveHoveredLinkRef,
@@ -345,16 +340,6 @@ export function TerminalPane({
 					);
 				},
 				onUrlClick: (event, url) => {
-					const pageSlug = parseSupersetPageUrl(url, env.NEXT_PUBLIC_WEB_URL);
-					if (pageSlug) {
-						event.preventDefault();
-						runUrlLinkAction(
-							linkActionDepsRef.current,
-							url,
-							preferences.pageOpenAction,
-						);
-						return;
-					}
 					const action = urlPolicy.getAction(event);
 					if (action === null) {
 						showHint(event.clientX, event.clientY);
@@ -378,7 +363,6 @@ export function TerminalPane({
 		filePolicy,
 		urlPolicy,
 		folderPolicy,
-		preferences.pageOpenAction,
 	]);
 
 	// Publish what a right-click landed on so the pane context menu (built in
@@ -670,7 +654,6 @@ export function TerminalPane({
 					urlPolicy,
 					folderPolicy,
 					worktreePath,
-					preferences.pageOpenAction,
 				)}
 				hoverPosition={hoveredLink}
 				clickHint={hint}
@@ -690,7 +673,6 @@ function resolveHoverLabel(
 	urlPolicy: ReturnType<typeof useTerminalUrlPolicy>,
 	folderPolicy: FolderClickPolicy,
 	worktreePath: string | undefined,
-	pageOpenAction: LinkAction,
 ): string | null {
 	if (!hovered) return null;
 	const event = {
@@ -699,11 +681,7 @@ function resolveHoverLabel(
 		shiftKey: hovered.shift,
 	};
 	if (hovered.info.kind === "url") {
-		const pageSlug = parseSupersetPageUrl(
-			hovered.info.url,
-			env.NEXT_PUBLIC_WEB_URL,
-		);
-		const action = pageSlug ? pageOpenAction : urlPolicy.getAction(event);
+		const action = urlPolicy.getAction(event);
 		return action ? actionLabel(action, "url") : null;
 	}
 	if (hovered.info.isDirectory) {

apps/desktop/src/renderer/routes/_authenticated/settings/browser/components/BrowserSettings/components/BrowserLinkSettings/BrowserLinkSettings.tsx

@@ -138,10 +138,7 @@ export function BrowserLinkSettings({
 									/>
 								</Label>
 								<p className="text-xs text-muted-foreground">
-									<Trans>
-										Where Page links in terminals, chat messages, and task
-										markdown open when clicked.
-									</Trans>
+									<Trans>Where pages open from a workspace's Pages menu.</Trans>
 								</p>
 							</div>
 							<Select

apps/desktop/src/renderer/routes/_authenticated/settings/utils/settings-search/settings-search.ts

@@ -1340,7 +1340,7 @@ export const SETTINGS_ITEMS: SettingsItem[] = [
 		section: "browser",
 		title: "Pages",
 		description:
-			"Whether Page links (in terminals, chat, and task markdown) open inside Superset or the system browser",
+			"Whether pages from a workspace's Pages menu open inside Superset or the system browser",
 		keywords: [
 			"links",
 			"page",

packages/i18n/locales/cs/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Jak si stojíte?"
 msgid "Where does my code run?"
 msgstr "Kde běží můj kód?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Kam se po kliknutí otevřou odkazy na stránky v terminálech, chatových zprávách a markdownu úkolů."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Kde se otevřou stránky z nabídky Stránky v pracovním prostoru."
 
 msgid "Where serious teams are"
 msgstr "Kde jsou seriózní týmy"

packages/i18n/locales/de/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Auf welchem Platz stehst du?"
 msgid "Where does my code run?"
 msgstr "Wo läuft mein Code?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Wohin Seiten-Links in Terminals, Chatnachrichten und Aufgaben-Markdown beim Klicken geöffnet werden."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Wo Seiten aus dem Seiten-Menü eines Arbeitsbereichs geöffnet werden."
 
 msgid "Where serious teams are"
 msgstr "Wo ernsthafte Teams stehen"

packages/i18n/locales/en/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Where do you rank?"
 msgid "Where does my code run?"
 msgstr "Where does my code run?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Where Page links in terminals, chat messages, and task markdown open when clicked."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Where pages open from a workspace's Pages menu."
 
 msgid "Where serious teams are"
 msgstr "Where serious teams are"

packages/i18n/locales/es/messages.po

@@ -17424,8 +17424,8 @@ msgstr "¿En qué puesto estás?"
 msgid "Where does my code run?"
 msgstr "¿Dónde se ejecuta mi código?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Dónde se abren los enlaces a páginas en terminales, mensajes de chat y markdown de tareas al hacer clic."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Dónde se abren las páginas desde el menú Páginas de un espacio de trabajo."
 
 msgid "Where serious teams are"
 msgstr "Donde están los equipos serios"

packages/i18n/locales/fr/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Quel est votre rang ?"
 msgid "Where does my code run?"
 msgstr "Où mon code s'exécute-t-il ?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Où s'ouvrent les liens vers des pages dans les terminaux, les messages de chat et le markdown des tâches lorsqu'on clique dessus."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Où s'ouvrent les pages depuis le menu Pages d'un espace de travail."
 
 msgid "Where serious teams are"
 msgstr "Là où en sont les équipes sérieuses"

packages/i18n/locales/id/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Di peringkat berapa Anda?"
 msgid "Where does my code run?"
 msgstr "Di mana kode saya berjalan?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Ke mana tautan Halaman di terminal, pesan chat, dan markdown tugas terbuka saat diklik."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Ke mana halaman dari menu Halaman di workspace terbuka."
 
 msgid "Where serious teams are"
 msgstr "Tempat tim serius berada"

packages/i18n/locales/it/messages.po

@@ -17424,8 +17424,8 @@ msgstr "In che posizione sei?"
 msgid "Where does my code run?"
 msgstr "Dove gira il mio codice?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Dove si aprono i link alle Pagine nei terminali, nei messaggi di chat e nel markdown dei task quando vengono cliccati."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Dove si aprono le pagine dal menu Pagine di un workspace."
 
 msgid "Where serious teams are"
 msgstr "Dove sono i team seri"

packages/i18n/locales/ja/messages.po

@@ -17424,8 +17424,8 @@ msgstr "あなたの順位は?"
 msgid "Where does my code run?"
 msgstr "コードはどこで実行されますか?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "ターミナル、チャットメッセージ、タスクの Markdown 内のページリンクをクリックしたときの開き先。"
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "ワークスペースのページメニューからページを開く場所。"
 
 msgid "Where serious teams are"
 msgstr "本気のチームの現在地"

packages/i18n/locales/ko/messages.po

@@ -17424,8 +17424,8 @@ msgstr "내 순위는 몇 위일까요?"
 msgid "Where does my code run?"
 msgstr "제 코드는 어디에서 실행되나요?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "터미널, 채팅 메시지, 작업 마크다운의 페이지 링크를 클릭했을 때 열리는 위치입니다."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "워크스페이스의 페이지 메뉴에서 페이지가 열리는 위치입니다."
 
 msgid "Where serious teams are"
 msgstr "진지한 팀들이 있는 곳"

packages/i18n/locales/nl/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Waar sta jij?"
 msgid "Where does my code run?"
 msgstr "Waar draait mijn code?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Waar Pagina-links in terminals, chatberichten en taak-markdown worden geopend bij een klik."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Waar pagina's uit het Pagina's-menu van een werkruimte worden geopend."
 
 msgid "Where serious teams are"
 msgstr "Waar serieuze teams staan"

packages/i18n/locales/pl/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Jaka jest twoja pozycja?"
 msgid "Where does my code run?"
 msgstr "Gdzie działa mój kod?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Gdzie po kliknięciu otwierają się linki do stron w terminalach, wiadomościach czatu i markdownie zadań."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Gdzie otwierają się strony z menu Strony w obszarze roboczym."
 
 msgid "Where serious teams are"
 msgstr "Tu są poważne zespoły"

packages/i18n/locales/pt-BR/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Qual é a sua posição?"
 msgid "Where does my code run?"
 msgstr "Onde o meu código roda?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Onde os links de páginas em terminais, mensagens de chat e markdown de tarefas abrem ao serem clicados."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Onde as páginas abrem a partir do menu Páginas de uma área de trabalho."
 
 msgid "Where serious teams are"
 msgstr "Onde os times sérios estão"

packages/i18n/locales/ru/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Какое у вас место?"
 msgid "Where does my code run?"
 msgstr "Где выполняется мой код?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Куда переходят ссылки на страницы в терминалах, сообщениях чата и markdown задач при нажатии."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Где открываются страницы из меню «Страницы» рабочей области."
 
 msgid "Where serious teams are"
 msgstr "Где сейчас серьёзные команды"

packages/i18n/locales/tr/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Kaçıncı sıradasınız?"
 msgid "Where does my code run?"
 msgstr "Kodum nerede çalışıyor?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Terminallerdeki, sohbet mesajlarındaki ve görev markdown'undaki Sayfa bağlantılarının tıklandığında nereye açılacağı."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Bir çalışma alanının Sayfalar menüsündeki sayfaların nerede açılacağı."
 
 msgid "Where serious teams are"
 msgstr "Ciddi takımların bulunduğu yer"

packages/i18n/locales/vi/messages.po

@@ -17424,8 +17424,8 @@ msgstr "Bạn xếp hạng bao nhiêu?"
 msgid "Where does my code run?"
 msgstr "Code của tôi chạy ở đâu?"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "Nơi các liên kết Trang trong terminal, tin nhắn trò chuyện và markdown tác vụ mở ra khi được nhấp."
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "Nơi các trang từ menu Trang của workspace được mở."
 
 msgid "Where serious teams are"
 msgstr "Nơi các đội nghiêm túc đang đứng"

packages/i18n/locales/zh-CN/messages.po

@@ -17424,8 +17424,8 @@ msgstr "你排第几？"
 msgid "Where does my code run?"
 msgstr "我的代码在哪里运行？"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "终端、聊天消息和任务 Markdown 中的页面链接点击后在何处打开。"
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "从工作区的页面菜单打开页面的位置。"
 
 msgid "Where serious teams are"
 msgstr "认真的团队都在这里"

packages/i18n/locales/zh-TW/messages.po

@@ -17424,8 +17424,8 @@ msgstr "你排第幾？"
 msgid "Where does my code run?"
 msgstr "我的程式碼在哪裡執行？"
 
-msgid "Where Page links in terminals, chat messages, and task markdown open when clicked."
-msgstr "終端機、聊天訊息和任務 Markdown 中的頁面連結點擊後在何處開啟。"
+msgid "Where pages open from a workspace's Pages menu."
+msgstr "從工作區的頁面選單開啟頁面的位置。"
 
 msgid "Where serious teams are"
 msgstr "認真的團隊都在這裡"