Skip to content

docs(recipe): Needs review is not shipped without tip-native proof - #7298

Closed
owieschon wants to merge 1 commit into
ParadevAI:mainfrom
owieschon:docs/proof-gate-thin-upstream
Closed

owieschon wants to merge 1 commit into
ParadevAI:mainfrom
owieschon:docs/proof-gate-thin-upstream

Conversation

@owieschon

@owieschon owieschon commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

What & why

Adds one docs page: docs/proof-gate-needs-review-receipt.md.

Needs review on the board is not shipped. Tip-native proof (check runs or a receipt pinned to the exact branch-tip SHA) is required first. Without that bar, Operators treat chrome as done and the product keeps lying about finished work.

How I tested it

  • Docs-only diff vs upstream main (single file) — branch cut from superset-sh/superset tip, not fork-main drift
  • Stay DRAFT — no undraft without CoS→Owen

Checklist

Supersedes #7296/#7297 (those heads sat on fork-main commits not yet in upstream).


Summary by cubic

Adds a docs page establishing that a workspace in Needs review is not shipped: operators must first see tip-native proof, either CI check runs or a receipt pinned to the exact branch-tip SHA.

This is a draft docs-only rule; it does not change product behavior, board columns, or agentStatus.

Written for commit f421563. Summary will update on new commits.

Review in cubic

Mechanism

Docs-only operator recipe. One page states that Needs review is a board column meaning needs review — not shipped — until a tip-native proof artifact (check runs or receipt) is pinned to the exact branch-tip SHA. No new columns, no host-service code, no agentStatus SoT changes (Todd #7007).

Session: OpenCode Alibaba overnight proof-gate → thin re-cut from upstream/main as docs/proof-gate-thin-upstream after fork-main drift closed #7296/#7297.

How I tested it

Operators must not treat the Needs review board column as shipped
without a tip-native proof artifact pinned to the branch-tip SHA.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@owieschon

Copy link
Copy Markdown
Contributor Author

Closing — this was internal operator practice, not an upstream product change. Keeping the bar in private doctrine; will land trust work as product behavior instead.

@owieschon owieschon closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant