Repository navigation
Conversation
Operators must not treat the Needs review board column as shipped without a tip-native proof artifact pinned to the branch-tip SHA.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 of 3 tasks
Contributor
Author
|
Closing — this was internal operator practice, not an upstream product change. Keeping the bar in private doctrine; will land trust work as product behavior instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds one docs page:
docs/proof-gate-needs-review-receipt.md.Needs review on the board is not shipped. Tip-native proof (check runs or a receipt pinned to the exact branch-tip SHA) is required first. Without that bar, Operators treat chrome as done and the product keeps lying about finished work.
How I tested it
main(single file) — branch cut fromsuperset-sh/supersettip, not fork-main driftChecklist
Supersedes #7296/#7297 (those heads sat on fork-main commits not yet in upstream).
Summary by cubic
Adds a docs page establishing that a workspace in Needs review is not shipped: operators must first see tip-native proof, either CI check runs or a receipt pinned to the exact branch-tip SHA.
This is a draft docs-only rule; it does not change product behavior, board columns, or
agentStatus.Written for commit f421563. Summary will update on new commits.
Mechanism
Docs-only operator recipe. One page states that Needs review is a board column meaning needs review — not shipped — until a tip-native proof artifact (check runs or receipt) is pinned to the exact branch-tip SHA. No new columns, no host-service code, no
agentStatusSoT changes (Todd #7007).Session: OpenCode Alibaba overnight proof-gate → thin re-cut from upstream/main as
docs/proof-gate-thin-upstreamafter fork-main drift closed #7296/#7297.How I tested it
/workspace/handoffs/pr7298-receipt-f42156340.mdf42156340fbdd528efa6b316e5793aee5b2270d5