Skip to content

chore(ci): drop the Clerk entries from turbo globalEnv - #7081

Merged
saddlepaddle merged 2 commits into
mainfrom
satya/drop-stale-clerk-env
Sep 2, 2026
Merged

saddlepaddle merged 2 commits into
mainfrom
satya/drop-stale-clerk-env

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 2, 2026 •

Copy link
Copy Markdown
Collaborator

Clerk stopped being the auth provider in January. NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY, NEXT_PUBLIC_CLERK_SIGN_IN_URL and NEXT_PUBLIC_CLERK_SIGN_UP_URL have no consumer in any app, no matching secret or variable in GitHub, and no reference in any workflow — but globalEnv is part of Turbo's cache key, so it kept hashing them.

Verified with an unfiltered repo-wide sweep. What remains and stays: migration history (immutable), a comment in CTAButtons.tsx explaining a real catch for stale Clerk cookies, and env.test.ts using CLERK_SECRET_KEY as a sample secret for a generic sanitizer.

The local-db columns are handled separately in #7080.

bun run lint and bun run typecheck pass.

https://claude.ai/code/session_01QAQLVm3xTUXsJhpPQo3Nuf


Summary by cubic

Removes NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY, NEXT_PUBLIC_CLERK_SIGN_IN_URL, and NEXT_PUBLIC_CLERK_SIGN_UP_URL from Turbo's globalEnv. These variables have no consumers or matching GitHub secrets since Clerk was replaced as the auth provider, but they were still hashed into the cache key.

Written for commit a34575c. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Removed three Clerk-related environment variables from the shared build configuration.
    • No user-facing functionality or behavior was changed.

Clerk stopped being the auth provider in January. These three variables have
no consumer in any app, no secret or variable in GitHub, and no reference in
any workflow — but globalEnv is part of Turbo's cache key, so it kept hashing
them.

Claude-Session: https://claude.ai/code/session_01QAQLVm3xTUXsJhpPQo3Nuf
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: d4ab8fd7-0eaf-4b75-a9f4-e90c262b6595

📥 Commits

Reviewing files that changed from the base of the PR and between 9550870 and a34575c.

📒 Files selected for processing (1)
  • turbo.jsonc
💤 Files with no reviewable changes (1)
  • turbo.jsonc

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Removes three Clerk-related environment variable names from the globalEnv array in turbo.jsonc.

Changes

Cohort / File(s) Summary
Turbo configuration
turbo.jsonc
Removes NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY, NEXT_PUBLIC_CLERK_SIGN_IN_URL, and NEXT_PUBLIC_CLERK_SIGN_UP_URL from globalEnv.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a3457

This change removes obsolete Clerk variables from Turbo's cache inputs without changing application behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly identifies the removal of obsolete Clerk entries from Turbo's global environment configuration.
Description check ✅ Passed The description explains what changed, why the variables were removed, what related references remain, and how the change was tested. It does not reproduce the template headings or checklist, but the …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains what changed, why the variables were removed, what related references remain, and how the change was tested. It does not reproduce the template headings or checklist, but the required information is mostly present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch satya/drop-stale-clerk-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 1946bd1 into main Sep 2, 2026
21 checks passed
@saddlepaddle
saddlepaddle deleted the satya/drop-stale-clerk-env branch September 2, 2026 00:50

This branch was previously deployed

1 inactive deployment
preview — a34575c3 Deployed Sep 2, 2026 by saddlepaddle via Deploy Marketing #8941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant