Repository navigation
chore(ci): drop the Clerk entries from turbo globalEnv - #7081
Conversation
Clerk stopped being the auth provider in January. These three variables have no consumer in any app, no secret or variable in GitHub, and no reference in any workflow — but globalEnv is part of Turbo's cache key, so it kept hashing them. Claude-Session: https://claude.ai/code/session_01QAQLVm3xTUXsJhpPQo3Nuf
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughRemoves three Clerk-related environment variable names from the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes obsolete Clerk variables from Turbo's cache inputs without changing application behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains what changed, why the variables were removed, what related references remain, and how the change was tested. It does not reproduce the template headings or checklist, but the required information is mostly present. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Clerk stopped being the auth provider in January.
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY,NEXT_PUBLIC_CLERK_SIGN_IN_URLandNEXT_PUBLIC_CLERK_SIGN_UP_URLhave no consumer in any app, no matching secret or variable in GitHub, and no reference in any workflow — butglobalEnvis part of Turbo's cache key, so it kept hashing them.Verified with an unfiltered repo-wide sweep. What remains and stays: migration history (immutable), a comment in
CTAButtons.tsxexplaining a real catch for stale Clerk cookies, andenv.test.tsusingCLERK_SECRET_KEYas a sample secret for a generic sanitizer.The local-db columns are handled separately in #7080.
bun run lintandbun run typecheckpass.https://claude.ai/code/session_01QAQLVm3xTUXsJhpPQo3Nuf
Summary by cubic
Removes
NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY,NEXT_PUBLIC_CLERK_SIGN_IN_URL, andNEXT_PUBLIC_CLERK_SIGN_UP_URLfrom Turbo'sglobalEnv. These variables have no consumers or matching GitHub secrets since Clerk was replaced as the auth provider, but they were still hashed into the cache key.Written for commit a34575c. Summary will update on new commits.
Summary by CodeRabbit