Repository navigation
feat(shared): add Kiro CLI as a built-in terminal agent - #6765
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThis change adds Kiro CLI as a built-in terminal agent. It defines command configurations, registers its icon, adds desktop and marketing integrations, tests the configuration, and updates documentation. ChangesKiro CLI support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds Kiro CLI support and related documentation and icons without any actionable merge-blocking risk remaining; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
|
Verified this against a live kiro-cli 2.19.0 install (IAM Identity Center login): the positional prompt into Three small additions you might want while you're in here (happy to send a follow-up PR instead if you'd rather keep this one tight):
I had independently built the same manifest (flag-identical) plus the first two of those integrations before spotting this PR — branch here if useful: https://github.com/bshaan77/superset/tree/feat/kiro-builtin-agent |
Adds AWS's Kiro CLI (`kiro-cli`) to BUILTIN_TERMINAL_AGENTS, with its preset icon, README row, docs bullet, and marketing demo entry. Rebased by hand from #3571 onto the current manifest shape: the prompt launch now seeds the interactive chat via the `[INPUT]` positional instead of `--no-interactive` (headless mode needs KIRO_API_KEY, which most interactive users do not have), resume uses `--resume-id`, and the headless form lives in nonInteractiveCommand. Kiro runs as a plain terminal agent, same shape as Pi / Cursor Agent, so no agent-setup target is needed. Co-authored-by: Hyunwoo Kim <13450715+Kcrong@users.noreply.github.com> Claude-Session: https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
83ec8dd to
a6d41c4
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…reset docs Follow-ups from review on #6765: icon-picker entry so custom agents can pick the Kiro icon, settings-search keywords, and the terminal-presets doc line, matching kimi/grok. Co-authored-by: Ishaan Bansal <35862574+bshaan77@users.noreply.github.com> Claude-Session: https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
… preset docs Follow-ups from review on #6765: icon-picker entry so custom agents can pick the Hermes icon, settings-search keywords, and the terminal-presets doc line, matching kimi/grok. Claude-Session: https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
…, and preset docs Follow-ups from review on #6765: icon-picker entry so custom agents can pick the Antigravity icon, settings-search keywords, and the terminal-presets doc line, matching kimi/grok. Claude-Session: https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
…set docs Follow-ups from review on #6765: icon-picker entry so custom agents can pick the fx icon, settings-search keywords, and the terminal-presets doc line, matching kimi/grok. Claude-Session: https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
|
Thank you @bshaan77 — both for the independent verification against a live kiro-cli (the --no-interactive lockdown test is a great data point, now noted here) and for catching the three integration spots. All three are in as of d764dc5: the icon-picker entry, settings-search keywords ("kiro", "aws" in both Agent commands and Quick Add Templates), and the terminal-presets.mdx line. Since the same gaps applied to the sibling PRs, the equivalent commits landed on #6766, #6767, and #6768 too. The commit carries your Co-authored-by — please do keep flagging things like this, it made the PR better. |
What
Adds Kiro CLI (AWS's spec-driven coding agent) as a built-in terminal agent. This is @Kcrong's #3571, rebased by hand onto the current
createBuiltinTerminalAgentmanifest shape and the files every builtin now touches. Thank you @Kcrong for the original contribution, the icon, and the flag verification; the commit carries yourCo-authored-by.packages/shared/src/builtin-terminal-agents.ts:kiroentrypackages/ui/src/assets/icons/preset-icons/kiro.svg+index.tsregistration (single icon; the mark sits on a#9046FFtile so it reads on light and dark, likeclaude/gemini/amp)apps/docs/content/docs/agent-integration.mdxbullet,UniversalCompatibilityDemoentry +apps/marketing/public/app-icons/kiro.svgagent-command.test.ts(prompt shape, preset args, resume args)Manifest
commandkiro-cli chat --trust-all-toolspromptCommandcommand; prompt goes in the[INPUT]positional, "The first question to ask")resumeCommandkiro-cli chat --trust-all-tools --resume-id(+ session id)nonInteractiveCommandkiro-cli chat --no-interactiveTwo deliberate changes from #3571:
promptCommandno longer uses--no-interactive. Headless mode requiresKIRO_API_KEY(Pro tier per the docs), so most interactive users would get an auth error on every prompt launch. Seeding the interactive chat positionally matches howgrok/piwork here; the headless form is kept innonInteractiveCommandwhere Superset uses it for one-shot work.droid/pi/polygraph. Happy to flipincludeInDefaultTerminalPresetsif you want it seeded.Kiro runs as a plain terminal agent, same shape as Pi / Cursor Agent, so no
packages/agent-setuptarget or wrapper is needed.Live-tested against an installed
kiro-cli2.19.1 on macOS (2026-08-23):chat --helpshows exactly the contract above ([INPUT]"The first question to ask",-a/--trust-all-tools,--resume-id <SESSION_ID>,--no-interactive). Real runs: the headless form answered a one-shot prompt; the interactive form booted, showed Kiro's one-time trust-all-tools acknowledgement (first launch only), answered the positional prompt in the TUI, and printed a--resume-idhint on exit;--resume-id <id>then resumed that conversation headlessly. One correction from testing to my paragraph above: headless mode worked here withoutKIRO_API_KEY(the docs' Pro-tier note evidently applies to API-key auth specifically, not to the mode) - the interactive-seeding choice stands on UX grounds regardless.Note: Kiro CLI 3.0 (opt-in via
kiro-cli --v3) replaces--trust-all-toolswith a capability-basedpermissions.yaml; the shipped 2.x default still accepts the flag, which is what this entry targets.Testing
bun run typecheckcleanbun run lintcleanbun test packages/shared778 passBased on #3571 (left open; the author can close it once this lands).
https://claude.ai/code/session_01DuAhw6Ao5Cru3acdkrzx9f
Summary by cubic
Adds Kiro CLI as a built-in terminal agent so users can run Kiro chats and resume sessions from Superset. Prompt launches now seed the interactive chat via positional input instead of headless; one-shot headless remains available.
kiro-cli chat --trust-all-tools; resume uses--resume-id; non-interactive useskiro-cli chat --no-interactive.packages/shared/src/agent-command.test.tscover registration, positional prompt injection, host preset args, and--resume-id.packages/ui, README row, docs entries inapps/docs(agent integration and terminal presets), desktopAgentIconPickeroption, settings-search keywords ("kiro", "aws"), and marketing icon plusUniversalCompatibilityDemoentry.--trust-all-tools); v3 replaces this with permissions, but 2.x still accepts the flag.Written for commit d764dc5. Summary will update on new commits.
Summary by CodeRabbit