Skip to content

fix(host-service): green main — account-env test expectations + lint info from #6645 - #6690

Closed
Kitenite wants to merge 1 commit into
mainfrom
fix-account-env-test-expectations
Closed

Kitenite wants to merge 1 commit into
mainfrom
fix-account-env-test-expectations

Conversation

@Kitenite

@Kitenite Kitenite commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

Main is currently red for every PR's Test and Lint jobs — both from #6645 as it landed (merge skew; its own CI predated the final shape).

What

  1. Test: resolveDefaultAccountEnv injects a SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR twin alongside CLAUDE_CONFIG_DIR (so the wrapper can re-resolve a later account switch without clobbering a user-exported value), but the two buildTerminalAgentLaunch default account env expectations in agents.test.ts still expect the pre-twin command. Updated both — including the pin-beats-default case, where the twin is still expected to point at the host default while the user's pinned CLAUDE_CONFIG_DIR wins.
  2. Lint: the same merge left a FIXABLE useTemplate info in agent-wrappers-claude-codex-opencode.ts, and scripts/lint.sh fails on any diagnostic. Applied biome's fix.

Verified

  • bun test src/trpc/router/agents/agents.test.ts — 27 pass, 0 fail (was 25/2 on pristine 22691eadc)
  • bash scripts/lint.sh . — clean (was Found 1 info → exit 1)

Summary by cubic

Unblocks red CI by aligning test expectations with resolveDefaultAccountEnv now injecting SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR alongside CLAUDE_CONFIG_DIR, and by applying a lint fix in the Claude wrapper. Previously tests expected only CLAUDE_CONFIG_DIR; now they expect both, with a pinned CLAUDE_CONFIG_DIR still winning while the twin points to the host default.

  • In packages/host-service/src/trpc/router/agents/agents.test.ts, update the two default account env expectations to include SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR; in the pinned case, the twin still references the host default.
  • In packages/agent-setup/src/agent-wrappers-claude-codex-opencode.ts, replace string concatenation with a template literal per biome’s useTemplate rule; behavior is unchanged.

Written for commit 1b710ee. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved Claude agent terminal launches by preserving the default configuration directory alongside any selected agent-specific configuration.
    • Ensured Claude wrapper command behavior remains consistent across supported launch scenarios.

…SUPERSET_DEFAULT_* twin

#6645 made resolveDefaultAccountEnv inject SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR
alongside CLAUDE_CONFIG_DIR but landed past these two expectations (merge
skew — its own CI predated the twin), leaving main's Test job red for every
PR. Also applies the fixable useTemplate lint info the same merge left in
agent-wrappers, which fails scripts/lint.sh's any-diagnostic gate.
@coderabbitai

coderabbitai Bot commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d12eaaa2-39b3-4865-b9cd-890735fb6877

📥 Commits

Reviewing files that changed from the base of the PR and between 22691ea and 1b710ee.

📒 Files selected for processing (2)
  • packages/agent-setup/src/agent-wrappers-claude-codex-opencode.ts
  • packages/host-service/src/trpc/router/agents/agents.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The PR changes Claude wrapper command construction syntax and updates launch tests to expect SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR alongside the selected CLAUDE_CONFIG_DIR.

Changes

Claude wrapper and launch expectations

Layer / File(s) Summary
Wrapper command and launch tests
packages/agent-setup/src/agent-wrappers-claude-codex-opencode.ts, packages/host-service/src/trpc/router/agents/agents.test.ts
The wrapper uses template-literal interpolation without changing command behavior. Tests cover default and agent-specific Claude configuration directories with SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1b710

This PR aligns test expectations with the existing account-environment behavior and applies a lint-only cleanup; no actionable merge-blocking risk remains after normal checks.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly describes the test expectation and lint fixes.
Description check ✅ Passed The description includes the changes, reasons, testing results, and checklist context required by the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-account-env-test-expectations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

@Kitenite

Copy link
Copy Markdown
Member Author

Superseded by #6694 — Kiet landed the same repair on main directly (test expectations + lint fix for #6645). Nothing left in this diff.

@Kitenite Kitenite closed this Aug 20, 2026
@Kitenite
Kitenite deleted the fix-account-env-test-expectations branch August 20, 2026 08:28

This branch was previously deployed

1 inactive deployment
preview — 1b710ee9 Deployed Aug 20, 2026 by Kitenite via Deploy Docs #8155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant