Repository navigation
Conversation
…SUPERSET_DEFAULT_* twin #6645 made resolveDefaultAccountEnv inject SUPERSET_DEFAULT_CLAUDE_CONFIG_DIR alongside CLAUDE_CONFIG_DIR but landed past these two expectations (merge skew — its own CI predated the twin), leaving main's Test job red for every PR. Also applies the fixable useTemplate lint info the same merge left in agent-wrappers, which fails scripts/lint.sh's any-diagnostic gate.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe PR changes Claude wrapper command construction syntax and updates launch tests to expect ChangesClaude wrapper and launch expectations
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR aligns test expectations with the existing account-environment behavior and applies a lint-only cleanup; no actionable merge-blocking risk remains after normal checks. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Main is currently red for every PR's Test and Lint jobs — both from #6645 as it landed (merge skew; its own CI predated the final shape).
What
resolveDefaultAccountEnvinjects aSUPERSET_DEFAULT_CLAUDE_CONFIG_DIRtwin alongsideCLAUDE_CONFIG_DIR(so the wrapper can re-resolve a later account switch without clobbering a user-exported value), but the twobuildTerminalAgentLaunch default account envexpectations inagents.test.tsstill expect the pre-twin command. Updated both — including the pin-beats-default case, where the twin is still expected to point at the host default while the user's pinnedCLAUDE_CONFIG_DIRwins.useTemplateinfo inagent-wrappers-claude-codex-opencode.ts, andscripts/lint.shfails on any diagnostic. Applied biome's fix.Verified
bun test src/trpc/router/agents/agents.test.ts— 27 pass, 0 fail (was 25/2 on pristine22691eadc)bash scripts/lint.sh .— clean (wasFound 1 info→ exit 1)Summary by cubic
Unblocks red CI by aligning test expectations with
resolveDefaultAccountEnvnow injectingSUPERSET_DEFAULT_CLAUDE_CONFIG_DIRalongsideCLAUDE_CONFIG_DIR, and by applying a lint fix in the Claude wrapper. Previously tests expected onlyCLAUDE_CONFIG_DIR; now they expect both, with a pinnedCLAUDE_CONFIG_DIRstill winning while the twin points to the host default.packages/host-service/src/trpc/router/agents/agents.test.ts, update the two default account env expectations to includeSUPERSET_DEFAULT_CLAUDE_CONFIG_DIR; in the pinned case, the twin still references the host default.packages/agent-setup/src/agent-wrappers-claude-codex-opencode.ts, replace string concatenation with a template literal per biome’suseTemplaterule; behavior is unchanged.Written for commit 1b710ee. Summary will update on new commits.
Summary by CodeRabbit