Repository navigation
fix(desktop): stop new-workspace suggestions overlapping the heading - #6557
Merged
Merged
Conversation
The suggestion block was positioned `absolute inset-x-6 bottom-full`, so it took no layout space. The heading above it is the flex-1 spacer, which therefore centered itself into space the suggestions then drew on top of — the cards rendered straight through "What should we build next?". This has been latent since the screen shipped in #5907 and only needed a tall enough suggestion set to show up. The returning-tier explain-superset card wrapped its title to two lines, which was enough. Putting the block back in flow fixes it structurally: the flex-1 heading absorbs the height, and because the composer block is bottom-anchored and PromptInput sits below the suggestions, the composer itself does not move — only the heading recenters. The root is already overflow-y-auto, so windows too short for both scroll rather than collide. Also shortens the explain-superset label to "Get more out of Superset" so the card title fits one line, which is better copy and keeps the block shorter regardless.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe new workspace modal now renders sample prompts in normal document flow. This prevents tall prompt sets from overlapping the heading. The Superset prompt label is shorter. ChangesNew workspace sample prompts
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized desktop change keeps suggestion cards in layout flow and shortens one label to prevent heading overlap; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suggestion cards render straight through the "What should we build next?" heading:
Cause
The suggestion block is positioned
absolute inset-x-6 bottom-full, so it takes no layout space. The heading above it is theflex-1spacer — it centers itself into whatever room is left, which includes the room the suggestions then draw on top of.Latent since the screen shipped in #5907; it just needed a tall enough suggestion set to surface. The returning-tier
explain-supersetcard wrapped its title to two lines, which was enough.Fix
Put the block back in flow. The
flex-1heading absorbs its height, so nothing overlaps at any window height.The composer does not move as a result: the composer block is bottom-anchored by
pb-8andPromptInputsits below the suggestions inside it, so only the heading recenters. On typing, the suggestions unmount and the heading drifts back down. The root is alreadyoverflow-y-auto, so a window too short for both scrolls rather than collides.Also shortens the
explain-supersetlabel to "Get more out of Superset" — one line instead of two, better copy, and it keeps the block shorter regardless of the layout fix.Verification
bun run typecheckand./scripts/lint.shpass. Not visually confirmed in the running app yet — flagging that explicitly rather than implying otherwise. Worth an eyeball on all three arms (control/cards2/cards4) before this is relied on, sincecards4is the tallest case.Summary by cubic
Prevents new-workspace suggestion cards from overlapping the "What should we build next?" heading. Previously the suggestions were absolutely positioned and drew over the heading; now the suggestions are in normal flow, so the heading absorbs their height and the composer stays bottom-anchored.
control,cards2,cards4) at various window heights;PromptInputposition should be unchanged and the root should scroll when space is tight.explain-supersetcard label is shortened to "Get more out of Superset" to reduce card height.Written for commit f538316. Summary will update on new commits.
Summary by CodeRabbit