Skip to content

fix: changes file double click behavior - #655

Merged
Kitenite merged 1 commit into
mainfrom
double-clicking-file
Jan 7, 2026
Merged

Kitenite merged 1 commit into
mainfrom
double-clicking-file

Conversation

@Kitenite

@Kitenite Kitenite commented Jan 7, 2026 •

Copy link
Copy Markdown
Member

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • New Features

    • Pinned file viewer panes now intelligently reuse existing matching panes based on file path, diff category, and commit, preventing unnecessary pane duplication.
  • Refactor

    • Simplified internal rendering architecture for improved code maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@Kitenite Kitenite changed the title Update double click behavior fix: changes file double click behavior Jan 7, 2026
@coderabbitai

coderabbitai Bot commented Jan 7, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two files are modified: the renderer root entry point has React import and StrictMode wrapper removed, and the tabs store's addFileViewerPane function now searches for and reuses existing pinned file-viewer panes matching the file path, diff category, and commit hash before creating new panes.

Changes

Cohort / File(s) Change Summary
Renderer Root Setup
apps/desktop/src/renderer/index.tsx
Removed React import and React.StrictMode wrapper; app now renders directly from AppProviders subtree
File Viewer Pane Management
apps/desktop/src/renderer/stores/tabs/store.ts
Modified addFileViewerPane to search for existing pinned panes matching file path, diff category, and commit hash; focuses and returns the pinned pane if found instead of proceeding to unpinned pane logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 No strict modes to mind,
Just panes pinned, carefully lined,
Reuse before creating anew,
Cleaner renders shine through! 📌✨

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b41c83 and a37da48.

📒 Files selected for processing (2)
  • apps/desktop/src/renderer/index.tsx
  • apps/desktop/src/renderer/stores/tabs/store.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite
Kitenite merged commit 8c0d3ca into main Jan 7, 2026
4 of 5 checks passed
@github-actions

github-actions Bot commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant