Skip to content

feat(desktop): show 'being reworked' placeholder in chat panes - #6409

Merged
Kitenite merged 1 commit into
mainfrom
superset-chat-under-const
Aug 13, 2026
Merged

Kitenite merged 1 commit into
mainfrom
superset-chat-under-const

Conversation

@Kitenite

@Kitenite Kitenite commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

What

Chat isn't functional right now, so this replaces the chat pane UI with a small "Chat is being reworked" placeholder in both the v1 (screens/main) and v2 (v2-workspace pane registry) chat panes, via a shared ChatUnderConstruction component.

Details

  • Pane chrome is preserved: title bar, split/close actions, and context menu still work, and existing/persisted chat panes mount without churn (v2 ChatPane keeps its props signature).
  • The v1 pane no longer initializes the chat runtime providers, IPC clients, or session controller, so none of the broken chat machinery runs.
  • No chat code is deleted — trivially revertible when chat comes back.
  • The flag-gated internal ChatV3Pane (CHAT_V3) is untouched.

Verification

Verified live via CDP against this worktree's dev desktop build: opened a v2 workspace → "Open Chat" → pane renders the placeholder with working pane chrome. Typecheck and bun run lint clean.


Summary by cubic

Render a “Chat is being reworked” placeholder in desktop chat panes to disable broken chat while keeping pane chrome and registry compatibility. Previously the v1/v2 panes initialized the legacy chat UI and runtime/providers; now they render a placeholder and do not start chat logic.

Reviewer notes

  • Adds shared ChatUnderConstruction component; used by v1 (screens/main) and v2 pane registry chat panes.
  • Pane chrome retained (title, split/close, context menu); persisted chat panes still mount; ChatPane props unchanged.
  • v1 pane no longer initializes chat runtime providers, IPC clients, or the session controller.
  • Flag-gated ChatV3Pane (CHAT_V3) is untouched.
  • No migration required; callers of ChatPane do not change.

Written for commit c686301. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Updates
    • Temporarily replaced the chat interface with a clear “under construction” message.
    • Preserved chat pane controls, including toolbar actions, context menus, split/close behavior, and tab movement.
    • Chat sessions and conversation interactions are currently unavailable while the experience is being reworked.

Chat isn't functional right now, so both the v1 and v2 chat panes render
a shared ChatUnderConstruction placeholder instead of the chat UI. Pane
chrome (title bar, split/close, context menu) is kept; the v1 pane no
longer initializes chat providers, IPC clients, or the session
controller. The flag-gated ChatV3Pane is untouched.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dc7edb7c-46a2-4fab-9707-72919a66a822

📥 Commits

Reviewing files that changed from the base of the PR and between 47080cb and c686301.

📒 Files selected for processing (4)
  • apps/desktop/src/renderer/components/ChatUnderConstruction/ChatUnderConstruction.tsx
  • apps/desktop/src/renderer/components/ChatUnderConstruction/index.ts
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/ChatPane/ChatPane.tsx
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx

📝 Walkthrough

Walkthrough

Desktop chat panes no longer initialize or render chat sessions. They now display a shared construction placeholder while preserving applicable pane controls and navigation actions.

Changes

Desktop chat placeholder

Layer / File(s) Summary
Add chat construction placeholder
apps/desktop/src/renderer/components/ChatUnderConstruction/ChatUnderConstruction.tsx, apps/desktop/src/renderer/components/ChatUnderConstruction/index.ts
Adds and exports a centered placeholder with a construction icon and rework message.
Replace chat pane implementations
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/ChatPane/ChatPane.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/ChatPane/ChatPane.tsx
Removes chat controller, session, provider, and interface wiring. Renders the placeholder while retaining existing pane controls and navigation actions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: 🔵 Low · up to c6863

The placeholder change is localized and preserves pane behavior, but previously persisted launch configurations may remain stale indefinitely. The PR is mergeable with explicit owner awareness or a follow-up cleanup.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly states that desktop chat panes now show a rework placeholder.
Description check ✅ Passed The description covers the change, rationale, preserved behavior, testing, and affected panes; it omits the template checklist but remains mostly complete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch superset-chat-under-const

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kitenite
Kitenite merged commit f716a19 into main Aug 13, 2026
12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant