Skip to content

fix(desktop): classify ENOENT spawn failures as PRECONDITION_FAILED, not 500 #6388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
Aug 12, 2026
+16 −5
Merged

fix(desktop): classify ENOENT spawn failures as PRECONDITION_FAILED, not 500 #6388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions apps/desktop/src/lib/trpc/routers/external/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { spawn } from "node:child_process";
import nodePath from "node:path";
import type { ExternalApp } from "@superset/local-db";
import { TRPCError } from "@trpc/server";

/** Map of app IDs to their macOS application names */
const MACOS_APP_NAMES: Record<ExternalApp, string | null> = {
Expand Down Expand Up @@ -384,11 +385,21 @@ export function spawnAsync(command: string, args: string[]): Promise<void> {
});

child.on("error", (error) => {
reject(
new Error(
`Failed to spawn '${command}': ${error.message}. Ensure the application is installed.`,
),
);
const message = `Failed to spawn '${command}': ${error.message}. Ensure the application is installed.`;
// ENOENT means the app's CLI launcher isn't installed / not on PATH —
// a user-environment condition, not a bug, so it must not surface as
// INTERNAL_SERVER_ERROR (which the Sentry middleware reports).
if ((error as NodeJS.ErrnoException).code === "ENOENT") {
reject(
new TRPCError({
code: "PRECONDITION_FAILED",
message,
cause: { kind: "APP_NOT_INSTALLED", command },
}),
);
return;
}
reject(new Error(message));
});

child.on("exit", (code) => {
Expand Down
Loading