Repository navigation
chore: remove unreferenced screenshot assets from the repo tree - #6272
Merged
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (15)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 8 files
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant Fork as Fork Branch
participant Main as Main Branch
participant GitHub as GitHub
participant PR as PR Description
Note over Dev,PR: Asset Storage & Reference Flow (Current State)
Dev->>Fork: Commit screenshots to .github/pr-assets/
Fork->>GitHub: Push branch with assets
Dev->>PR: Create PR referencing fork's raw.githubusercontent.com URLs
PR->>Fork: Render screenshots from fork branch
Note over Fork,Main: PR Merge & Reference Resolution
PR->>Main: PR merged to main
Main->>Main: Assets land in .github/pr-assets/ on main
PR->>GitHub: PR description now references fork branch (not main)
GitHub-->>PR: Screenshots still render from fork
Note over Main,GitHub: Unreferenced Resource Pattern
Main->>GitHub: Clone includes .github/pr-assets/ (644 KB)
GitHub-->>Main: Binary blobs persist in repo history
Main->>Main: git grep pr-assets returns only asset files (no references)
Three groups of binary assets with zero references anywhere in the tree: - .github/pr-assets/ (644K): PR #6201's description screenshots; the description embeds the fork's raw URLs, so these copies serve nothing - assets/ (211K): example.png/notifs.png orphaned since the website moved into apps/marketing - apps/desktop/docs/assets/v1-migration-notices/ (1.2M): PR #6118 evidence screenshots never linked from any doc; the v1 surface is sunset Kept: apps/desktop/docs/artifacts (referenced by two runbooks) and packages/cli/demo recordings (outputs of the committed vhs demo kit).
Kitenite
force-pushed
the
chore/remove-pr-screenshot-assets
branch
from
August 8, 2026 00:28
1e70c4a to
f7d2a6a
Compare
Kitenite
changed the title
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Removes three groups of binary assets that nothing in the tree references (verified with
git grepper path — zero hits outside the assets themselves), totaling ~2MB in every clone:.github/pr-assets/(644K) — PR feat(desktop): add multi-repo work item filters and PR checks #6201 committed its eight description screenshots here, but the description embeds the fork'sraw.githubusercontent.comURLs, so the copies onmainwere never used. Removing them also avoids setting a precedent of storing PR imagery in the tree.assets/(211K) —example.pngandnotifs.pngat the repo root, orphaned since the website moved intoapps/marketing(last touched 2025-11-30, "update website").apps/desktop/docs/assets/v1-migration-notices/(1.2M) — five screenshots added with feat(desktop): pre-flip notice + post-flip welcome for migrated v1 users #6118 as PR evidence, never linked from any doc; the v1 surface they depict is sunset.Deliberately kept:
apps/desktop/docs/artifacts/renderer-churn-visible-lifecycle-checkpoints.mp4— referenced by two runbook docs.packages/cli/demo/*.gif|mp4(4.9M) — unreferenced by any markdown, but they're the outputs of the committed vhs demo kit (superset-cli.tape,add-sound.sh) and plausibly reused for marketing; flagging rather than deleting.How I tested it
git grepfor each removed filename/directory onmainreturns only the assets themselves