[Kitenite]

Summary

• The local main workspace row in the v2 sidebar no longer shows the hover minus ("Remove from sidebar") button — a stray click on it removed the project's anchor row and reset the workspace's pane layout.
• Deliberate removal is untouched: the row context menu's "Remove from Sidebar", the command palette command, and the Workspaces-page unpin all still work. Remote mains keep the minus button; worktree rows keep their close (X) button.

Manual QA

Verified over CDP against the real dev app (before/after): with the change stashed, the local main row rendered the minus button and a click removed the row; with the change applied, the local main row renders no hover action button while the worktree row's close button and the context-menu removal path still work end-to-end.

Testing

• bun run typecheck (desktop, exit 0)
• bun run lint (exit 0)

Summary by CodeRabbit

• Bug Fixes
  • Updated workspace sidebar actions to show only the options applicable to each workspace type.
  • Local main workspaces no longer display remove or close actions.
  • Other main workspaces retain the remove option, while non-main workspaces retain the close option.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4dc72063-cf74-4511-8a62-b7462a7f27be

📥 Commits

Reviewing files that changed from the base of the PR and between 2e80a46 and 29284ab.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/DashboardSidebarExpandedWorkspaceRow.tsx

---

📝 Walkthrough

Walkthrough

The expanded workspace row now identifies local main workspaces. It hides remove and close actions for those workspaces while preserving existing actions for other workspace types.

Changes

Local main workspace protection

Layer / File(s)	Summary
Workspace action visibility apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/DashboardSidebarExpandedWorkspaceRow.tsx	The component identifies local main workspaces and renders neither remove nor close actions for them. Other workspace action behavior remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• superset-sh/superset#5146: Modifies the same workspace-row action logic for pin, unpin, and delete behavior.
• superset-sh/superset#5392: Modifies the same component’s remove and close action behavior.
• superset-sh/superset#5887: Changes conditional workspace actions in the same component.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses conventional commit format and clearly states the main fix: preventing local main workspace removal from the v2 sidebar.
Description check	✅ Passed	The description explains the problem, implementation, affected removal paths, testing, and known limitations, with only the template checklist omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch prevent-local-workspace-r

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

The PR prevents the local main workspace from being removed independently of its project while preserving removal behavior for worktrees and remote mains.

• Hides or disables removal controls in the sidebar, command palette, and Workspaces page.
• Adds a shared mutation guard that refuses to tombstone the local main workspace.
• Keeps project-level removal and restoration of previously hidden local mains unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with the local-main protection applied consistently across current removal surfaces and the shared mutation path.

The UI predicates use local identity derived from the same machine-ID comparison as the state-layer guard, while worktree and remote-main removal behavior remains reachable.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/commandPalette/modules/workspace/commands.tsx	Suppresses the remove-from-sidebar command when the active workspace is the local main.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarExpandedWorkspaceRow/DashboardSidebarExpandedWorkspaceRow.tsx	Removes the hover removal control from local-main sidebar rows while retaining existing controls for remote mains and worktrees.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceContextMenu/DashboardSidebarWorkspaceContextMenu.tsx	Hides local-main removal from the context menu and conditionally preserves correct menu grouping.
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspaces/components/V2WorkspacesList/components/V2WorkspaceRow/V2WorkspaceRow.tsx	Disables local-main unpin actions in the Workspaces page UI and handler.
apps/desktop/src/renderer/routes/_authenticated/hooks/useDashboardSidebarState/useDashboardSidebarState.ts	Adds the central state-layer guard preventing local-main sidebar tombstones.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Removal request] --> B{Local main workspace?}
  B -->|Yes| C[Hide or disable UI affordance]
  C --> D[Mutation guard refuses tombstone]
  B -->|No| E[Invoke hideWorkspaceInSidebar]
  E --> F[Tombstone sidebar workspace record]

Loading

_{Reviews (1): Last reviewed commit: 13cf103 | Re-trigger Greptile}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.