Repository navigation
fix(desktop): remove doubled border between workspace panes and right sidebar - #6171
Conversation
…le the panel edge Claude-Session: https://claude.ai/code/session_015mBAauusSAewcv7JHm5pAw
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe sidebar tab mapping now tracks tab indexes. The first tab receives a transparent left border to avoid duplicating the resizable panel’s sidebar edge. ChangesSidebar tab border adjustment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Greptile SummaryThe PR removes the doubled divider beside the v2 workspace sidebar by making the first tab’s left border transparent while retaining the resizable panel’s border.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The change is narrowly scoped to the first rendered tab’s left border color and preserves the existing border width and fixed tab ordering.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/components/SidebarHeader/SidebarHeader.tsx | Correctly suppresses the first tab’s redundant border color without changing tab dimensions or behavior. |
Reviews (1): Last reviewed commit: "fix(desktop): drop first sidebar tab's l..." | Re-trigger Greptile
Summary
The v2 workspace sidebar's tab header uses the inverted tab style where the active tab draws a 1px border on all sides. When the leftmost tab (Files) is active, its left border sits flush against the
ResizablePanel'sborder-l, rendering a 2px doubled divider across the tab-header row.Fix: make the first tab's left border transparent — the resizable panel already draws the sidebar's left edge. Inactive tabs already had a transparent left border, so nothing else changes.
Test Plan
https://claude.ai/code/session_015mBAauusSAewcv7JHm5pAw
Summary by cubic
Removes the doubled 2px divider between the main pane and the right sidebar by making the first sidebar tab’s left border transparent. Ensures a single, consistent 1px divider across the tab header with no layout shift when switching tabs.
Written for commit 7ac34b1. Summary will update on new commits.
Summary by CodeRabbit