Skip to content

fix(desktop): remove doubled border between workspace panes and right sidebar - #6171

Merged
saddlepaddle merged 1 commit into
mainfrom
fix-doubled-borders
Aug 5, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
fix-doubled-borders

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Aug 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The v2 workspace sidebar's tab header uses the inverted tab style where the active tab draws a 1px border on all sides. When the leftmost tab (Files) is active, its left border sits flush against the ResizablePanel's border-l, rendering a 2px doubled divider across the tab-header row.

Fix: make the first tab's left border transparent — the resizable panel already draws the sidebar's left edge. Inactive tabs already had a transparent left border, so nothing else changes.

Test Plan

  • Open a v2 workspace with the right sidebar visible and the Files tab active — the divider between the panes and the sidebar is a single 1px line across the tab-header row
  • Switch between Files/Changes/Review tabs — no layout shift, divider stays single

https://claude.ai/code/session_015mBAauusSAewcv7JHm5pAw


Summary by cubic

Removes the doubled 2px divider between the main pane and the right sidebar by making the first sidebar tab’s left border transparent. Ensures a single, consistent 1px divider across the tab header with no layout shift when switching tabs.

Written for commit 7ac34b1. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Improved the workspace sidebar’s visual alignment by preventing a duplicated border on the first tab next to the resizable panel.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2507cfb6-68fd-44e1-9795-10fadbd08a93

📥 Commits

Reviewing files that changed from the base of the PR and between 68672e4 and 7ac34b1.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/components/SidebarHeader/SidebarHeader.tsx

📝 Walkthrough

Walkthrough

The sidebar tab mapping now tracks tab indexes. The first tab receives a transparent left border to avoid duplicating the resizable panel’s sidebar edge.

Changes

Sidebar tab border adjustment

Layer / File(s) Summary
Apply first-tab border styling
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/components/SidebarHeader/SidebarHeader.tsx
The tab iteration captures each tab index. The first tab conditionally receives border-l-transparent; later tabs retain the existing classes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: avipeltz, kitenite

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-doubled-borders

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@saddlepaddle
saddlepaddle merged commit 3de6113 into main Aug 5, 2026
11 of 12 checks passed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR removes the doubled divider beside the v2 workspace sidebar by making the first tab’s left border transparent while retaining the resizable panel’s border.

  • Passes the tab index through the sidebar-header render loop.
  • Applies border-l-transparent only to the leftmost tab.
  • Preserves border width, avoiding layout shifts when switching tabs.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The change is narrowly scoped to the first rendered tab’s left border color and preserves the existing border width and fixed tab ordering.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/components/WorkspaceSidebar/components/SidebarHeader/SidebarHeader.tsx Correctly suppresses the first tab’s redundant border color without changing tab dimensions or behavior.

Reviews (1): Last reviewed commit: "fix(desktop): drop first sidebar tab's l..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant