Repository navigation
fix(desktop): inline actionable clone errors in onboarding project step - #6116
Merged
Merged
Conversation
Replace the auto-dismissing clone-failure toast with a persistent inline error under the clone input. Auth-shaped git failures (repo not found, auth failed, no username, publickey denied) map to a human cause with a Sign in to GitHub CLI button that opens GhAuthDialog in place; other errors render their raw message inline and selectable. Also switch the placeholder to an HTTPS example since SSH keys are unchecked.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe project onboarding page now handles GitHub CLI authentication during cloning. It stores structured clone errors, displays failures inline, clears errors during retries or URL edits, and opens ChangesProject clone authentication
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ProjectPage
participant CloneOperation
participant GhAuthDialog
ProjectPage->>CloneOperation: Start project clone
CloneOperation-->>ProjectPage: Return clone failure
ProjectPage->>ProjectPage: Normalize and store clone error
ProjectPage->>GhAuthDialog: Open dialog for authentication-required failure
GhAuthDialog-->>ProjectPage: Return dialog state or exit
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
End-to-end CDP verification (real dev app, worktree renderer on vite port 8105, CDP 9613, matched page target before driving):
All checks were end-to-end through the real renderer (onboarding gate armed by nulling |
Kitenite
marked this pull request as ready for review
August 2, 2026 00:18
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx (1)
30-30: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse the configured
rendererpath alias forGhAuthDialog.The new import uses a relative path while this file uses
renderer/...aliases for local modules. Use the configured alias to keep the import stable if the route directory moves.Proposed import
-import { GhAuthDialog } from "../components/GhAuthDialog"; +import { GhAuthDialog } from "renderer/routes/_authenticated/onboarding/components/GhAuthDialog";As per coding guidelines, use the path aliases defined in
tsconfig.jsonwhen possible.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx` at line 30, Update the GhAuthDialog import in the onboarding project page to use the configured renderer path alias instead of the relative path, matching the existing local-module import convention.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx`:
- Around line 41-57: Scope the GitHub CLI authentication classification in
toCloneError to failures from the GitHub clone operation only, rather than
applying message-pattern matching to the outer onboarding catch that also
handles readiness, project creation, setup, and navigation. Track the clone
operation and GitHub host context, or use typed provider metadata, so unrelated
errors—including host-service messages containing authentication or repository
text—cannot set needsGhAuth; add regression coverage for non-GitHub and
non-clone failures.
- Around line 250-254: Update the cloneError message container in the onboarding
page to expose the asynchronous failure through an assertive live region, such
as role="alert". Keep the existing cloneError.message rendering and styling
unchanged.
---
Nitpick comments:
In `@apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx`:
- Line 30: Update the GhAuthDialog import in the onboarding project page to use
the configured renderer path alias instead of the relative path, matching the
existing local-module import convention.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f9448b63-9a0b-4ffc-ae09-909c9140ffbe
📒 Files selected for processing (1)
apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx">
<violation number="1" location="apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx:41">
P2: When an SSH URL clone fails with "Permission denied (publickey)", the new inline error tells the user to sign in to GitHub CLI and shows the corresponding button. But that failure means the SSH key isn't authorized for the host — the PR even states SSH keys are an unchecked prerequisite and switched the placeholder to HTTPS to steer away from SSH. Signing in to `gh` does not fix an unauthorized SSH key, so the user would click "Sign in to GitHub CLI", complete the flow, retry, and hit the same error. Consider dropping "Permission denied (publickey)" from the GH-auth pattern set (or special-casing it with an SSH-specific message, e.g. add your SSH key to the host), rather than routing it through the GH CLI sign-in affordance.</violation>
</file>
Architecture diagram
sequenceDiagram
participant UI as Clone Form UI
participant State as React State (url, cloneError, ghAuthOpen)
participant CloneHandler as Handle Clone Submit
participant HostService as Local Host Service
participant ProjectAPI as V2 Cloud Project API
participant GhAuth as GhAuthDialog
Note over UI,GhAuth: Clone Repository Flow (Onboarding Step 2)
UI->>UI: User enters HTTPS URL
UI->>State: setUrl(url)
UI->>UI: User clicks "Clone" button
UI->>CloneHandler: handleClone()
CloneHandler->>State: setCloneError(null), setBusy(true)
alt Host service not ready
CloneHandler->>State: setCloneError({message, needsGhAuth:false})
CloneHandler->>State: setBusy(false)
State-->>UI: Inline error displayed
else Host service ready
CloneHandler->>HostService: waitForHostReady()
HostService-->>CloneHandler: activeHostUrl
CloneHandler->>ProjectAPI: createProject(url)
alt Clone succeeds
ProjectAPI-->>CloneHandler: projectId
CloneHandler->>UI: finish() - navigate away
else Clone fails
ProjectAPI-->>CloneHandler: Error with stderr message
CloneHandler-->>CloneHandler: toCloneError(message)
alt Auth-related failure (GH_AUTH_FAILURE_PATTERNS)
CloneHandler->>State: setCloneError({message:"Couldn't access...", needsGhAuth:true})
State-->>UI: Inline error + "Sign in to GitHub CLI" button
UI->>UI: User clicks "Sign in"
UI->>State: setGhAuthOpen(true)
UI->>GhAuth: Open dialog
GhAuth-->>UI: Auth flow completed
UI->>State: setGhAuthOpen(false)
UI->>UI: User retries clone (same URL)
else Other failure
CloneHandler->>State: setCloneError({message:raw stderr, needsGhAuth:false})
State-->>UI: Inline error (raw message)
end
end
end
Note over UI: User edits URL - clear error
UI->>State: setUrl(newValue)
alt cloneError exists
State->>State: setCloneError(null)
State-->>UI: Error removed
end
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Comment on lines
+41
to
+46
| const GH_AUTH_FAILURE_PATTERNS = [ | ||
| "Repository not found", | ||
| "Authentication failed", | ||
| "could not read Username", | ||
| "Permission denied (publickey)", | ||
| ]; |
Contributor
There was a problem hiding this comment.
P2: When an SSH URL clone fails with "Permission denied (publickey)", the new inline error tells the user to sign in to GitHub CLI and shows the corresponding button. But that failure means the SSH key isn't authorized for the host — the PR even states SSH keys are an unchecked prerequisite and switched the placeholder to HTTPS to steer away from SSH. Signing in to gh does not fix an unauthorized SSH key, so the user would click "Sign in to GitHub CLI", complete the flow, retry, and hit the same error. Consider dropping "Permission denied (publickey)" from the GH-auth pattern set (or special-casing it with an SSH-specific message, e.g. add your SSH key to the host), rather than routing it through the GH CLI sign-in affordance.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop/src/renderer/routes/_authenticated/onboarding/project/page.tsx, line 41:
<comment>When an SSH URL clone fails with "Permission denied (publickey)", the new inline error tells the user to sign in to GitHub CLI and shows the corresponding button. But that failure means the SSH key isn't authorized for the host — the PR even states SSH keys are an unchecked prerequisite and switched the placeholder to HTTPS to steer away from SSH. Signing in to `gh` does not fix an unauthorized SSH key, so the user would click "Sign in to GitHub CLI", complete the flow, retry, and hit the same error. Consider dropping "Permission denied (publickey)" from the GH-auth pattern set (or special-casing it with an SSH-specific message, e.g. add your SSH key to the host), rather than routing it through the GH CLI sign-in affordance.</comment>
<file context>
@@ -27,11 +27,35 @@ import { EmptyProjectModal } from "renderer/routes/_authenticated/components/Emp
+ needsGhAuth: boolean;
+}
+
+const GH_AUTH_FAILURE_PATTERNS = [
+ "Repository not found",
+ "Authentication failed",
</file context>
Suggested change
| const GH_AUTH_FAILURE_PATTERNS = [ | |
| "Repository not found", | |
| "Authentication failed", | |
| "could not read Username", | |
| "Permission denied (publickey)", | |
| ]; | |
| const GH_AUTH_FAILURE_PATTERNS = [ | |
| "Repository not found", | |
| "Authentication failed", | |
| "could not read Username", | |
| ]; |
…le=alert Address review: map GitHub CLI advice only for errors thrown by the clone mutation itself (non-clone failures show their raw message with no gh action), give Permission denied (publickey) SSH-specific copy pointing at the HTTPS URL, and announce the inline error via role=alert.
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SUPER-1729 — https://linear.app/superset-sh/issue/SUPER-1729
Onboarding step 2's "Clone a repo" card used to surface clone failures as a sonner toast of raw git stderr that fades in ~4s, with no hint that private repos 404 when GitHub CLI isn't signed in, and no retry affordance.
Changes
select-text cursor-textper the renderer's selectable-error rule.GhAuthDialogon this step; the entered URL stays intact for an immediate retry. Unmatched errors show their raw message inline instead of a toast.https://github.com/org/repo.git(SSH keys are an unchecked prerequisite).Other cards (create, open folder, template), step 1, GhAuthDialog internals, and Continue/navigation logic are untouched.
Verification
bun run lint:fix+bun run lintexit 0apps/desktopbun run typecheckpassesSummary by CodeRabbit
New Features
Bug Fixes
Screenshot evidence (CDP-verified)
Before (SUPER-1729 walkthrough): raw git stderr in a toast that auto-dismissed in ~4s —
After:
Images live on the
evidence/super-1729branch (never merge; deletable after the PRs land).