Skip to content

fix(desktop): migrate terminal reconnect onto createRelaySocket (forever-retry + retryCount diagnosis) #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 4 commits into from
Jul 15, 2026
Merged

fix(desktop): migrate terminal reconnect onto createRelaySocket (forever-retry + retryCount diagnosis) #5702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ee943e
feat(workspace-client): expose relay preflight probe via onProbe
Kitenite Jul 15, 2026
48e69a0
fix(desktop): migrate terminal reconnect onto createRelaySocket
Kitenite Jul 15, 2026
8d516b5
test(desktop): stop terminal transport mock leaking across the suite
Kitenite Jul 15, 2026
53ffa82
fix(desktop): guard stale socket events + epoch-guard relay preflight
Kitenite Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions apps/desktop/src/renderer/lib/terminal/terminal-runtime-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
connect,
createTransport,
disposeTransport,
reconnect,
sendDispose,
sendInput,
sendResize,
Expand Down Expand Up @@ -204,19 +205,14 @@ class TerminalRuntimeRegistryImpl {
}

/**
* Manually re-dial the last URL after the transport stopped trying (gave
* up on max attempts, access denied, fatal server error). connect() clears
* the terminated flag, so this restarts a dead loop.
* Manually re-dial after the transport stopped trying (access denied, fatal
* server error, PTY exit). reconnect() clears the terminated flag and forces
* an immediate dial, restarting a dead loop.
*/
retryConnect(terminalId: string, instanceId = terminalId) {
const entry = this.getEntry(terminalId, instanceId);
if (!entry?.runtime) return;
const url = entry.transport.currentUrl;
if (!url) return;
// Manual retry gets a full backoff budget, like reconnectNow(); the
// exhausted counter would otherwise block scheduling any follow-up.
entry.transport._reconnectAttempt = 0;
connect(entry.transport, entry.runtime.terminal, url);
reconnect(entry.transport);
}

/**
Expand Down
Loading
Loading