Skip to content

fix(desktop,web): bump @xterm/* to beta.289 line for shared-atlas garble fix #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AviPeltz merged 2 commits into from
Jul 16, 2026
Merged

fix(desktop,web): bump @xterm/* to beta.289 line for shared-atlas garble fix #5701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f781aa
fix(desktop,web): bump @xterm/* to beta.289 line for shared-atlas gar…
AviPeltz Jul 15, 2026
fbb89b9
fix(desktop): hold @xterm/addon-ligatures at beta.220 to unbreak vite…
AviPeltz Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,17 +151,17 @@
"@types/express": "5.0.6",
"@types/pidusage": "2.0.5",
"@vercel/blob": "2.3.2",
"@xterm/addon-clipboard": "0.3.0-beta.220",
"@xterm/addon-fit": "0.12.0-beta.220",
"@xterm/addon-image": "0.10.0-beta.220",
"@xterm/addon-clipboard": "0.3.0-beta.289",
"@xterm/addon-fit": "0.12.0-beta.289",
"@xterm/addon-image": "0.10.0-beta.289",
"@xterm/addon-ligatures": "0.11.0-beta.220",
"@xterm/addon-progress": "0.3.0-beta.220",
"@xterm/addon-search": "0.17.0-beta.220",
"@xterm/addon-serialize": "0.15.0-beta.220",
"@xterm/addon-unicode11": "0.10.0-beta.220",
"@xterm/addon-webgl": "0.20.0-beta.219",
"@xterm/headless": "6.1.0-beta.220",
"@xterm/xterm": "6.1.0-beta.220",
"@xterm/addon-progress": "0.3.0-beta.289",
"@xterm/addon-search": "0.17.0-beta.289",
"@xterm/addon-serialize": "0.15.0-beta.289",
"@xterm/addon-unicode11": "0.10.0-beta.289",
"@xterm/addon-webgl": "0.20.0-beta.288",
"@xterm/headless": "6.1.0-beta.289",
"@xterm/xterm": "6.1.0-beta.289",
"ai": "6.0.141",
"better-auth": "1.6.13",
"better-sqlite3": "12.6.2",
Expand Down
4 changes: 2 additions & 2 deletions apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"@trpc/server": "11.16.0",
"@trpc/tanstack-react-query": "11.16.0",
"@uiw/react-md-editor": "4.1.0",
"@xterm/addon-fit": "0.12.0-beta.220",
"@xterm/xterm": "6.1.0-beta.220",
"@xterm/addon-fit": "0.12.0-beta.289",
"@xterm/xterm": "6.1.0-beta.289",
"better-auth": "1.6.13",
"framer-motion": "12.38.0",
"geist": "1.7.0",
Expand Down
48 changes: 24 additions & 24 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions bunfig.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,20 @@
linker = "isolated" # Prevent hoisting from resolving `path-scurry@2` to `lru-cache@6` (missing `LRUCache`), which breaks the `@superset/desktop` postinstall native rebuild.
exact = true
minimumReleaseAge = 259200
# @xterm beta.288/289 (published 2026-07-13) ships the shared-atlas page-merge
# garble fix (xtermjs/xterm.js#6042); versions are pinned exact. Safe to remove
# this exclusion after 2026-07-16. (addon-ligatures stays on beta.220: its
# beta.289 bundle imports node:diagnostics_channel, which breaks the vite
# renderer build.)
minimumReleaseAgeExcludes = [
"@xterm/xterm",
"@xterm/headless",
"@xterm/addon-clipboard",
"@xterm/addon-fit",
"@xterm/addon-image",
"@xterm/addon-progress",
"@xterm/addon-search",
"@xterm/addon-serialize",
"@xterm/addon-unicode11",
"@xterm/addon-webgl",
]
Comment on lines +10 to +21

@greptile-apps greptile-apps Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Temporary exclusion needs a follow-up to be removed

minimumReleaseAgeExcludes bypasses the 3-day supply-chain gate and the comment marks it safe to remove after 2026-07-16 — but there is nothing enforcing that cleanup (no CI check, no lint rule, no expiry mechanism). Because exact = true already pins these packages, the exclusion is low-risk to leave behind, but it does permanently widen the gate for the entire @xterm/* scope for anyone who runs bun install with version resolution in the future. A follow-up PR or a TODO ticket to remove these lines after 2026-07-16 would ensure it doesn't linger.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: bunfig.toml
Line: 8-20

Comment:
**Temporary exclusion needs a follow-up to be removed**

`minimumReleaseAgeExcludes` bypasses the 3-day supply-chain gate and the comment marks it safe to remove after 2026-07-16 — but there is nothing enforcing that cleanup (no CI check, no lint rule, no expiry mechanism). Because `exact = true` already pins these packages, the exclusion is low-risk to leave behind, but it does permanently widen the gate for the entire `@xterm/*` scope for anyone who runs `bun install` with version resolution in the future. A follow-up PR or a TODO ticket to remove these lines after 2026-07-16 would ensure it doesn't linger.

How can I resolve this? If you propose a fix, please make it concise.

2 changes: 1 addition & 1 deletion packages/host-service/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"@t3-oss/env-core": "0.13.11",
"@trpc/client": "11.16.0",
"@trpc/server": "11.16.0",
"@xterm/headless": "6.1.0-beta.220",
"@xterm/headless": "6.1.0-beta.289",
"better-sqlite3": "12.6.2",
"drizzle-orm": "0.45.2",
"hono": "4.12.25",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"devDependencies": {
"@superset/typescript": "workspace:*",
"@types/friendly-words": "1.2.2",
"@xterm/xterm": "6.1.0-beta.220",
"@xterm/xterm": "6.1.0-beta.289",
"bun-types": "1.3.14",
"typescript": "6.0.3"
}
Expand Down
Loading