Repository navigation
feat(desktop): enable inline workspace ports and agents row by default - #5483
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 9a37f1a on Jul 6, 2026 9:10pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo experiment stores' default persisted ChangesExperiment Default Flips
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR enables two desktop sidebar experiments by default. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/stores/inline-workspace-ports.ts | Changes the persisted inline workspace ports experiment default from disabled to enabled. |
| apps/desktop/src/renderer/stores/workspace-agents-row.ts | Changes the persisted workspace agents row experiment default from disabled to enabled and updates the comment. |
Reviews (1): Last reviewed commit: "feat(desktop): enable inline workspace p..." | Re-trigger Greptile
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 2 files
Architecture diagram
sequenceDiagram
participant User
participant SidebarUI as Sidebar UI
participant SettingsUI as Experimental Settings
participant Store as Zustand Store (persist)
participant LS as localStorage
Note over Store,LS: Applies to both inline-workspace-ports and workspace-agents-row
User->>SidebarUI: App loads / workspace renders
SidebarUI->>Store: Read enabled state(s)
Store->>LS: getItem("inline-workspace-ports" / "workspace-agents-row")
alt No persisted value (first visit / cleared)
LS-->>Store: null
Store->>Store: Use default true (NEW default)
else Persisted value exists
LS-->>Store: stored boolean
Store->>Store: Use stored value (user preference)
end
Store-->>SidebarUI: enabled = true/false
SidebarUI->>SidebarUI: Render ports / agents inline if enabled
Note over SidebarUI: Ports and agents appear under each workspace item
User->>SettingsUI: Toggle experiment flag
SettingsUI->>Store: setEnabled(newValue)
Store->>Store: Update internal state
Store->>LS: setItem(...) via persist middleware
Store-->>SettingsUI: State updated
SettingsUI-->>User: UI reflects toggle
SidebarUI->>Store: Re-read enabled (reactive via zustand)
Store-->>SidebarUI: new value
SidebarUI->>SidebarUI: Re-render inline content accordingly
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
Flips both experimental sidebar flags on by default:
inline-workspace-portsstore) — ports render inline under each workspace item instead of the bottom panel.workspace-agents-rowstore) — running agents render inline under each workspace item.Both remain toggleable in Experimental Settings. Since the stores use zustand
persist, users who never toggled pick up the newtruedefault; anyone who explicitly set a value keeps their choice.Test Plan
Summary by cubic
Turn on inline workspace ports and the workspace agents row by default so ports and running agents show directly under each workspace in the sidebar. Both experiments remain toggleable in Experimental Settings; defaults only apply to users who never changed them, thanks to
zustandpersist.Written for commit 9a37f1a. Summary will update on new commits.
Summary by CodeRabbit