Skip to content

fix(desktop): bake OAuth client IDs into main process at build time #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 2 commits into from
Dec 19, 2025
Merged

fix(desktop): bake OAuth client IDs into main process at build time #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82087c4
fix(desktop): bake OAuth client IDs into main process at build time
saddlepaddle Dec 19, 2025
fa5ede4
fix(desktop): explicitly pass env vars to runtimeEnv for Vite replace…
saddlepaddle Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/desktop/electron.vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ export default defineConfig({
"process.env.NODE_ENV": JSON.stringify(
process.env.NODE_ENV || "production",
),
// API URLs - baked in at build time for main process
"process.env.NEXT_PUBLIC_API_URL": JSON.stringify(
process.env.NEXT_PUBLIC_API_URL || "https://api.superset.sh",
),
"process.env.NEXT_PUBLIC_WEB_URL": JSON.stringify(
process.env.NEXT_PUBLIC_WEB_URL || "https://app.superset.sh",
),
// OAuth client IDs - baked in at build time for main process
"process.env.GOOGLE_CLIENT_ID": JSON.stringify(
process.env.GOOGLE_CLIENT_ID,
),
"process.env.GH_CLIENT_ID": JSON.stringify(process.env.GH_CLIENT_ID),
},

build: {
Expand Down
6 changes: 6 additions & 0 deletions apps/desktop/src/main/env.main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ export const env = createEnv({

runtimeEnv: {
...process.env,
// Explicitly list env vars so Vite can replace them at build time
// (spreading process.env only works at runtime, not for bundled apps)
NODE_ENV: process.env.NODE_ENV,
NEXT_PUBLIC_API_URL: process.env.NEXT_PUBLIC_API_URL,
NEXT_PUBLIC_WEB_URL: process.env.NEXT_PUBLIC_WEB_URL,
GOOGLE_CLIENT_ID: process.env.GOOGLE_CLIENT_ID,
GH_CLIENT_ID: process.env.GH_CLIENT_ID,
},
emptyStringAsUndefined: true,

Expand Down
Loading