Skip to content

fix(desktop): preserve terminal history across re-renders #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 1 commit into from
Dec 19, 2025
Merged

fix(desktop): preserve terminal history across re-renders #425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...derer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,9 @@ export const Terminal = ({ tabId, workspaceId }: TerminalProps) => {
if (initialCommands || initialCwd) {
clearPaneInitialDataRef.current(paneId);
}
const hasPendingEvents = pendingEventsRef.current.length > 0;
if (result.isNew || !hasPendingEvents) {
applyInitialState(result);
}
// Always apply initial state (scrollback) first, then flush pending events
// This ensures we don't lose terminal history when reattaching
applyInitialState(result);
setSubscriptionEnabled(true);
flushPendingEvents();
},
Expand Down
Loading