Repository navigation
fix(desktop): refresh terminal renderer after reattach - #3506
Closed
dorukardahan wants to merge 1 commit into
Closed
dorukardahan wants to merge 1 commit into
dorukardahan wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
This keeps the terminal redraw path consistent after a pane was detached, reattached, resized, or occluded on macOS.
The goal is narrow. This PR does not disable WebGL, does not disable ligatures, and does not change renderer selection. It only makes the existing WebGL path refresh from a clean texture atlas before repainting.
Nearby risk: the app has two terminal lifecycle paths. This change updates both so the recovery logic does not drift between them.
Tests
bun test apps/desktop/src/renderer/lib/terminal/terminal-renderer.test.tsbun test apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/**/*.test.ts apps/desktop/src/renderer/lib/terminal/terminal-renderer.test.ts apps/desktop/src/renderer/lib/terminal/*.test.tscd apps/desktop && bun run typecheckReal-world validation
Issue
Fixes #3504
Summary by cubic
Fixes stale or blank terminal frames on macOS by clearing the WebGL texture atlas and forcing a repaint after reattach, resize, font changes, or context loss. Unifies the recovery path across both terminal lifecycles and adds a focused test. Fixes #3504.
refreshTerminalRendererhelper that clears the WebGL texture atlas (via@xterm/addon-webgl) and calls a fullrefresh.Written for commit 9c23287. Summary will update on new commits.