[Kitenite]

Summary

• Press Escape on any settings page to navigate back to where settings was opened from (originRoute).
• Uses react-hotkeys-hook with enableOnFormTags: false and enableOnContentEditable: false, so Escape inside inputs, textareas, selects, and contenteditable fields is left to the browser/component.
• Skips navigation if any Radix overlay is open ([data-state="open"]), so Escape-to-close on dialogs/popovers/dropdowns/sheets keeps working as expected.

Test plan

• Open settings from main, press Escape → returns to origin route.
• Type in the search input, press Escape → does not navigate (input keeps focus).
• Open a dialog (e.g. Invite Member, Edit Secret), press Escape → dialog closes, settings stays.
• Open a dropdown/popover (e.g. Volume, Font Family), press Escape → popover closes, settings stays.
• Press Escape with focus in a textarea (e.g. Scripts editor) → does not navigate.

---

Summary by cubic

Close Settings with Escape in the desktop app. Pressing Escape on any Settings page returns you to where Settings was opened.

• New Features
  • Uses react-hotkeys-hook with form and contenteditable inputs excluded, so Escape inside fields is not intercepted.
  • Skips navigation when any Radix overlay is open, preserving Escape-to-close for dialogs, popovers, dropdowns, and sheets.

^{Written for commit 6206829. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Enhanced Escape key behavior in Settings: Pressing Escape now intelligently closes any open dialogs or panels before navigating back to the previous page.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc80efba-760a-46f6-ac6f-6a33a33f0d01

📥 Commits

Reviewing files that changed from the base of the PR and between 4ee2e61 and 6206829.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx

---

📝 Walkthrough

Walkthrough

Added Escape key handling to the settings layout component. When pressed, it checks for open UI elements; if none exist, it navigates back to the origin route using the newly introduced useSettingsOriginRoute() hook.

Changes

Cohort / File(s)	Summary
Settings Layout Escape Key Handler apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx	Integrated useHotkeys for Escape key to conditionally navigate back to origin route, with logic to bypass navigation if an open element is detected via [data-state="open"] selector.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 The Escape key hops with grace,
Checking if the UI's in place,
No open doors? Then away we race,
Back to where we started in this settings space! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch allow-escape-key-to-return-from-settings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

[greptile-apps]

Greptile Summary

This PR adds an Escape key shortcut to close the settings layout in the desktop app by navigating back to originRoute. The implementation hooks into react-hotkeys-hook at the settings layout level and is consistent with the existing codebase patterns.

Key changes:

• Adds useHotkeys("escape", ...) to SettingsLayout using the already-installed react-hotkeys-hook library
• Sets enableOnFormTags: false and enableOnContentEditable: false so Escape inside inputs, textareas, selects, and contenteditable elements is not intercepted
• Guards navigation with a document.querySelector('[data-state="open"]') check so open Radix overlays (dialogs, popovers, dropdowns, sheets) handle Escape first before navigation is attempted
• Behavior is fully symmetric with the existing sidebar "Back" <Link to={originRoute}> — no extra state cleanup is performed, which is consistent with that existing pattern

Confidence Score: 5/5

Safe to merge — single focused change, correct guard conditions, consistent with existing codebase patterns.

The implementation is a clean, minimal addition that mirrors existing hotkey patterns in the codebase (useHotkey.ts uses the same 4-argument useHotkeys signature). The enableOnFormTags: false default correctly prevents navigation when form elements are focused, the [data-state="open"] guard is the standard Radix UI convention and correctly defers to overlay Escape handling, and the navigate({ to: originRoute }) call is exactly what the existing sidebar Back button does. No new dependencies are introduced, and the behavior is fully covered by the PR's own test plan.

No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/routes/_authenticated/settings/layout.tsx	Adds a useHotkeys("escape") handler that navigates back to originRoute; guards against open Radix overlays and active form elements correctly, consistent with existing hotkey usage patterns in the codebase.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant HK as useHotkeys (Escape)
    participant DOM as document.querySelector
    participant R as Radix Overlay
    participant Nav as TanStack navigate

    U->>HK: Press Escape (focus NOT in form/contenteditable)
    HK->>DOM: querySelector('[data-state="open"]')
    alt Radix overlay is open
        DOM-->>HK: element found
        HK->>R: return early — overlay handles Escape natively
        R->>R: closes dialog/popover/dropdown
    else No overlay open
        DOM-->>HK: null
        HK->>HK: event.preventDefault()
        HK->>Nav: navigate({ to: originRoute })
        Nav-->>U: navigates back to origin route
    end

    Note over U,HK: Escape inside input/textarea/select/contenteditable<br/>is never captured (enableOnFormTags: false)

Loading

_{Reviews (1): Last reviewed commit: "feat(desktop): close settings with Escap..." | Re-trigger Greptile}