Skip to content

fix(desktop): focus xterm when v2 pane becomes active via FOCUS_PANE_* hotkey #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manoffortune wants to merge 1 commit into from
Closed

fix(desktop): focus xterm when v2 pane becomes active via FOCUS_PANE_* hotkey #3465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,12 @@ export function TerminalPane({ ctx, workspaceId }: TerminalPaneProps) {
[terminalId, connectionState],
);

// Physically move keyboard focus when this pane becomes active via hotkey (e.g. FOCUS_PANE_*)
useEffect(() => {
if (!ctx.isActive || !terminal) return;
terminal.focus();
}, [ctx.isActive, terminal]);

// biome-ignore lint/correctness/useExhaustiveDependencies: connectionState is intentionally included to trigger re-derive
const searchAddon = useMemo(
() => terminalRuntimeRegistry.getSearchAddon(terminalId),
Expand Down