[Kitenite]

Summary

• react-hotkeys-hook skips keydown events whose target is contentEditable unless enableOnContentEditable is set. CodeMirror 6 (v1 file editor) uses a contenteditable editor area, so cmd+w never reached the CLOSE_TERMINAL handler at workspace/$workspaceId/page.tsx:220 while the editor was focused.
• Default enableOnContentEditable: true in useHotkey, mirroring the existing enableOnFormTags: true default. Callers can still opt out via options.

Test plan

• Focus a file in the v1 file editor, press cmd+w → pane closes.
• Unsaved changes prompt still triggers on cmd+w in a dirty file editor.
• Other app chords (cmd+s save, cmd+f find) still behave as before inside the editor.
• cmd+w still closes terminal / chat / browser panes when those are focused.

---

Summary by cubic

Restore cmd+w to close the focused pane when the v1 file editor (CodeMirror) is focused by allowing app hotkeys to fire inside contentEditable editors.

• Bug Fixes
  • Default enableOnContentEditable: true in useHotkey (mirrors enableOnFormTags: true); callers can override via options.
  • Addresses react-hotkeys-hook skipping keydown on contentEditable (CodeMirror), so cmd+w reaches the close handler again without changing other shortcuts.

^{Written for commit 45d877b. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Enabled hotkey handling on content-editable elements, allowing keyboard shortcuts to function properly in editable text areas.

[coderabbitai]

📝 Walkthrough

Walkthrough

The hotkey hook configuration is extended to enable hotkey handling on contentEditable elements by adding enableOnContentEditable: true to the useHotkeys setup, alongside the existing enableOnFormTags: true setting.

Changes

Cohort / File(s)	Summary
Hotkey Configuration Enhancement apps/desktop/src/renderer/hotkeys/hooks/useHotkey/useHotkey.ts	Added enableOnContentEditable: true to the useHotkeys configuration to support hotkey handling on contentEditable elements.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line, so small and neat,
Makes contentEditable hotkeys sweet,
Now typing zones obey commands true,
One tiny change, so clean and new! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description covers the problem, solution, and test plan, but the author-provided section lacks the structured template (Bug fix checkbox, Related Issues, etc.) that is required.	Complete the PR description using the template structure: fill in the Type of Change checkboxes, add Related Issues links, and ensure Testing section is detailed.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change—enabling hotkeys on contentEditable elements—which directly addresses the PR's core objective of restoring cmd+w functionality in the CodeMirror v1 file editor.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch restore-cmd-w-close

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR fixes cmd+w not closing the pane when a v1 file editor (CodeMirror 6) was focused. CodeMirror 6 renders an editor area as a contenteditable div, and react-hotkeys-hook skips keydown events targeting contentEditable elements by default — so the CLOSE_TERMINAL handler never fired.

The fix adds enableOnContentEditable: true to the defaults in the shared useHotkey wrapper, mirroring the already-present enableOnFormTags: true. Because ...options is spread after the defaults, any individual call-site can still opt out by passing { enableOnContentEditable: false }.

Key observations:

• The change is a single-line addition, minimal in scope.
• The approach is consistent with the existing enableOnFormTags: true default, which already caused all globally-registered hotkeys to fire inside <input>, <textarea>, and <select> elements.
• This is a desktop IDE-like application; workspace navigation shortcuts (close pane, switch tab, etc.) are expected to work regardless of which element has focus.
• Chat shortcut registrations in ChatShortcuts already guard their activation with { enabled: isFocused }, so no regressions are expected there.
• No currently-registered hotkeys overlap with standard editing operations (undo, copy, bold, etc.), so no text-editing conflicts are introduced.

Confidence Score: 5/5

Safe to merge — minimal, targeted fix with no identified regressions.

Single-line change that mirrors an existing default (enableOnFormTags: true). The ...options spread preserves per-call-site opt-out. No registered hotkeys overlap with standard editing shortcuts, and existing call-sites that guard by focus ({ enabled: isFocused }) are unaffected. Test plan covers the primary bug path and adjacent cases.

No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/hotkeys/hooks/useHotkey/useHotkey.ts	Adds enableOnContentEditable: true as a default alongside the existing enableOnFormTags: true, so all hotkeys registered via useHotkey now fire when focus is inside a contenteditable element (e.g. CodeMirror 6 editor). Callers can still opt out via options.

Sequence Diagram

sequenceDiagram
    participant User
    participant CodeMirror as CodeMirror 6 (contenteditable)
    participant RHKH as react-hotkeys-hook
    participant useHotkey
    participant Handler as CLOSE_TERMINAL handler

    Note over RHKH: Before fix: enableOnContentEditable defaults to false

    User->>CodeMirror: Focuses editor
    User->>CodeMirror: Presses cmd+w
    CodeMirror->>RHKH: keydown event (target=contenteditable)
    RHKH--xHandler: Skipped — contenteditable target

    Note over RHKH: After fix: enableOnContentEditable: true in useHotkey defaults

    User->>CodeMirror: Focuses editor
    User->>CodeMirror: Presses cmd+w
    CodeMirror->>RHKH: keydown event (target=contenteditable)
    RHKH->>useHotkey: Hotkey match — passes through
    useHotkey->>Handler: Calls CLOSE_TERMINAL callback
    Handler-->>User: Pane closes

Loading

_{Reviews (1): Last reviewed commit: "fix(desktop): let app hotkeys fire insid..." | Re-trigger Greptile}

[cubic-dev-ai]

No issues found across 1 file

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉