Repository navigation
fix(desktop): keep OS clipboard chords (Cmd+C/V/X/A) bubbling out of v1 terminal #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Event Taxonomy | ||
|
|
||
| Blueprint refs: P1, P2, P6, P8, P19. | ||
|
|
||
| Status: seed. Add events only through typed helpers/proxy; do not scatter vendor SDK calls. | ||
|
|
||
| | Event | Journey | When | Required fields | Forbidden fields | | ||
| | --- | --- | --- | --- | --- | | ||
| | `superset.journey_started` | TBD | User/system intent accepted | `correlation_id`, `surface`, `environment`, `app_version` | raw content, token, email, phone | | ||
| | `superset.journey_completed` | TBD | Business success confirmed | `correlation_id`, `result`, `success` | raw content, token, email, phone | | ||
| | `superset.journey_failed` | TBD | Bounded failure class known | `correlation_id`, `error_class`, `success` | raw error message as label | | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||
| # Observability Field Registry | ||||||
|
|
||||||
| Blueprint source: company-wide `observability-blueprint.md`. This repo adapts the contract; it does not fork the blueprint. | ||||||
|
|
||||||
| | Field | Type | Headers | Logs | Spans | Metric labels | Notes | | ||||||
| | --- | --- | --- | --- | --- | --- | --- | | ||||||
| | `request_id` | generated id | yes | yes | yes | no | One HTTP/IPC/job operation. | | ||||||
| | `trace_id` | W3C trace id | `traceparent` | yes | native | no | Full journey trace. | | ||||||
| | `span_id` | W3C span id | `traceparent` | yes | native | no | Current operation span. | | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: The Prompt for AI agents
Suggested change
|
||||||
| | `correlation_id` | generated id | yes | yes | yes | no | One business action/retry chain. | | ||||||
| | `actor_id` | hashed/pseudonymous id | yes | yes | yes | no | Never raw email/phone/customer id. | | ||||||
| | `session_id` | session id | optional | yes | yes | no | Browser/app session. | | ||||||
| | `app_version` | bounded string | yes | yes | yes | yes | Release/git SHA/build id. | | ||||||
| | `environment` | enum | optional | yes | yes | yes | `development`, `staging`, `production`. | | ||||||
| | `surface` | enum | yes | yes | yes | yes | `web`, `api`, `worker`, `job`, `desktop`, `mobile`, `gateway`. | | ||||||
| | `route` | template | no | yes | yes | yes | No raw URLs or query strings. | | ||||||
| | `operation` | bounded string | optional | yes | yes | yes | Business operation name. | | ||||||
| | `result` | enum | optional | yes | yes | yes | `success`, `failure`, `cancelled`, `timeout`, `fallback`. | | ||||||
| | `success` | string enum | optional | yes | yes | yes | Use `"true"`/`"false"` for labels. | | ||||||
| | `error_class` | bounded enum | optional | yes | yes | yes | Never raw error message as a label. | | ||||||
|
|
||||||
| Rules: | ||||||
| - IDs are fine in logs/traces, not metric labels. | ||||||
| - Raw stable identifiers stay local unless explicitly approved. | ||||||
| - Telemetry helpers must redact tokens, cookies, emails, phones, prompts, raw files, webhook URLs, and URL query secrets. | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Observability Journeys | ||
|
|
||
| ## J1 — user sends chat/tool request | ||
|
|
||
| Start: TBD. | ||
| Success: TBD. | ||
| Failure/timeout/cancel: TBD. | ||
| Required signals: product event, structured log, metric, trace/span. | ||
|
|
||
| ## J2 — runtime executes provider call | ||
|
|
||
| Start: TBD. | ||
| Success: TBD. | ||
| Failure/timeout/cancel: TBD. | ||
| Required signals: product event, structured log, metric, trace/span. | ||
|
|
||
| ## J3 — desktop/web session recovers from error | ||
|
|
||
| Start: TBD. | ||
| Success: TBD. | ||
| Failure/timeout/cancel: TBD. | ||
| Required signals: product event, structured log, metric, trace/span. | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Observability Query Reference | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Unrelated observability documentation file added inside a focused desktop clipboard bugfix PR. This couples a docs contract change to a bugfix, increasing review/rollback risk and violating the team's keep-PRs-focused guidance. Prompt for AI agents |
||
|
|
||
| Status: initial repo contract. Fill datasource names when Grafana/OTel/PostHog/Sentry wiring lands. | ||
|
|
||
| ## Canonical labels | ||
|
|
||
| - `environment`: `development`, `staging`, `production` | ||
| - `surface`: `web`, `api`, `worker`, `job`, `desktop`, `mobile`, `gateway` | ||
| - `success`: `"true"` or `"false"` | ||
| - `route`: route templates only | ||
| - `operation`: bounded business operation names | ||
|
|
||
| ## Baseline metrics expected | ||
|
|
||
| - `api_requests_total` or repo equivalent | ||
| - `http_server_request_duration_seconds` | ||
| - `job_runs_total` | ||
| - `job_duration_seconds` | ||
| - `external_dependency_requests_total` | ||
| - `external_dependency_duration_seconds` | ||
| - `telemetry_events_accepted_total` | ||
| - `telemetry_events_rejected_total` | ||
| - `telemetry_events_dropped_total` | ||
| - `telemetry_export_failures_total` | ||
|
|
||
| ## Missing-data taxonomy | ||
|
|
||
| Empty dashboard can mean: no traffic, no failures, broken exporter, wrong query function, wrong environment label, not deployed yet, ingestion delay, datasource/query error. | ||
|
|
||
| ## False query traps | ||
|
|
||
| - Do not query raw URLs; use route templates. | ||
| - Do not group metrics by generated IDs or user hashes. | ||
| - Do not use `rate()` on serverless event gauges; use the documented function for that metric type. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # superset Observability System Overview | ||
|
|
||
| Blueprint source: company-wide `observability-blueprint.md`. Vendor stack can vary; principle IDs do not. | ||
|
|
||
| Repo: `/Users/aytuncyildizli/superset` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Machine-specific absolute local path with username is committed in shared documentation. Replace Prompt for AI agents |
||
| Surface: agent/desktop/web app surface | ||
|
|
||
| ## Minimum contract | ||
|
|
||
| - Correlation: `request_id`, `trace_id`, `span_id`, `correlation_id`, privacy-safe `actor_id`. | ||
| - Signals: structured logs, metrics, traces/manual business spans, product/client events where applicable. | ||
| - Privacy: no raw secrets, prompts, files, emails, phone numbers, webhook URLs, cookies, or raw customer ids in telemetry. | ||
| - Operations: health and readiness are separate; dashboards/alerts/runbooks live in source control. | ||
|
|
||
| ## Implementation status | ||
|
|
||
| RED until this repo has real helpers/tests/wiring. This directory is the source-control contract seed. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Runbook: Observability Triage | ||
|
|
||
| ## First checks | ||
|
|
||
| 1. Is `/health` live or equivalent process liveness green? | ||
| 2. Is `/ready` or dependency readiness green? | ||
| 3. Are metrics/logs/traces present for the expected `environment`? | ||
| 4. Are recent deploy/version labels visible? | ||
| 5. Is missing data caused by no traffic, broken exporter, wrong label, or ingestion delay? | ||
|
|
||
| ## Privacy guard | ||
|
|
||
| Do not paste raw logs if they may contain secrets, prompts, files, emails, phone numbers, webhook URLs, cookies, session strings, or raw customer ids. Redact first. | ||
|
|
||
| ## Escalation | ||
|
|
||
| - SEV1: core journey unavailable, data loss, security/privacy incident. | ||
| - SEV2: major journey degraded for meaningful user segment. | ||
| - SEV3: partial degradation, elevated errors, workaround exists. | ||
| - SEV4: low-impact anomaly/investigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Completion and failure journey events should require the same
environmentandapp_versiondimensions as the start event, or the document should explicitly state that the typed proxy auto-enriches them. Otherwise the taxonomy cannot support consistent end-to-end observability slicing (e.g., failure rates by version or environment).Prompt for AI agents