Skip to content

fix/build ci - #212

Merged
Kitenite merged 1 commit into
mainfrom
fix/build-ci
Dec 1, 2025
Merged

Kitenite merged 1 commit into
mainfrom
fix/build-ci

Conversation

@Kitenite

@Kitenite Kitenite commented Dec 1, 2025 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated desktop application build configuration to modify the publishing behavior during the build process.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel

vercel Bot commented Dec 1, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Dec 1, 2025 7:18pm

@coderabbitai

coderabbitai Bot commented Dec 1, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The build script in the desktop package configuration was updated to add the --publish never flag to the electron-builder command. This flag prevents automatic publishing of the built application during the build process.

Changes

Cohort / File(s) Summary
Build configuration
apps/desktop/package.json
Updated the build script to append --publish never flag to the electron-builder command, disabling automatic publish behavior

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A tiny flag, so small and neat,
Stops the builder in its fleet,
"Never publish," the command now says,
Control returned through build's new ways! 🏗️

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty; the author provided no description content and did not fill in any sections of the required template. Add a description following the provided template, including details about what changed, why it was necessary, and any related issues or testing performed.
Title check ❓ Inconclusive The title 'fix/build ci' is vague and lacks specificity about the actual change; it doesn't clearly convey what CI issue is being fixed or what the build modification accomplishes. Consider a more descriptive title such as 'Disable publishing in electron-builder' or 'Prevent auto-publish on build' to better communicate the change.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/build-ci

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22bbe26 and faddba6.

📒 Files selected for processing (1)
  • apps/desktop/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-28T01:03:47.963Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-28T01:03:47.963Z
Learning: Use Bun as the package manager - no npm, yarn, or pnpm

Applied to files:

  • apps/desktop/package.json
📚 Learning: 2025-11-28T01:03:47.963Z
Learnt from: CR
Repo: superset-sh/superset PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-28T01:03:47.963Z
Learning: Applies to apps/desktop/electron.vite.config.ts : Load `.env` file with `override: true` in Vite configuration for build-time environment variable access

Applied to files:

  • apps/desktop/package.json
🔇 Additional comments (1)
apps/desktop/package.json (1)

23-23: Good separation of build and publishing concerns.

The --publish never flag is a valid electron-builder option and correctly prevents publishing during the build step. This aligns well with the PR objective and establishes clear script responsibilities: build compiles without publishing, while release (line 28) handles publishing with --publish always. This is a sound CI/CD pattern.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite
Kitenite merged commit 49c8ac4 into main Dec 1, 2025
7 checks passed
@Kitenite
Kitenite deleted the fix/build-ci branch December 1, 2025 19:27

This branch was successfully deployed

1 active deployment
Preview — faddba67 Deployed Dec 1, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant