[Kitenite]

Summary

• The sidebar's getStatus query had a 2-second server-side cache that returned stale git state after mutations (stage, unstage, commit, push, etc.)
• When a mutation completed and the client called refetch(), the server returned cached data because the TTL hadn't expired
• The 2.5s client-side polling interval already rate-limits queries, making the server cache redundant

Changes

• apps/desktop/src/lib/trpc/routers/changes/status.ts: Removed the statusCache Map, STATUS_CACHE_TTL_MS constant, and all cache read/write logic from getStatus

Test Plan

• Stage/unstage a file and verify the sidebar updates immediately
• Make a commit and verify staged files clear from the sidebar without delay
• Push/pull and verify counts update promptly
• Verify no perceptible performance regression from removing the cache

Summary by CodeRabbit

• Chores
  • Removed caching layer from status computation to retrieve updated status on each request.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

📝 Walkthrough

Walkthrough

This pull request removes server-side caching from the getStatus endpoint in the changes router. The STATUS_CACHE_TTL_MS constant, statusCache instance, and cache lookup/storage logic are eliminated, causing the function to always compute and return a fresh GitChangesStatus object instead of serving cached results.

Changes

Cohort / File(s)	Summary
Cache removal apps/desktop/src/lib/trpc/routers/changes/status.ts	Removed server-side caching mechanism including cache TTL constant, cache instance, cache lookup logic, and cache storage calls. Function now directly returns computed GitChangesStatus without intermediate caching layer.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• superset-sh/superset#1453: Modifies the same getStatus router to remove workspace-branch sync side effects.
• superset-sh/superset#679: Restructures and parallelizes internal operations in the same getStatus implementation.
• superset-sh/superset#1495: Introduces a new hook that relies on the getStatus endpoint touched by this PR.

Poem

🐰 No cache today, fresh answers bloom,
Each call computes, banishing gloom,
The rabbit hops with lighter code,
Down simplicity's cleaner road! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removing server-side status cache that was causing stale sidebar data.
Description check	✅ Passed	The PR description effectively explains the problem, rationale, and changes made, with a clear test plan, though it lacks formal sections matching the template structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/sidebar-invalidate-or-refetch-force

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app
• ⚠️ Streams Fly.io app

Thank you for your contribution! 🎉