keep terminal tabs rendered by Kitenite · Pull Request #147 · ParadevAI/Paradev

Kitenite · 2025-11-26T07:07:31Z

Summary by CodeRabbit

Release Notes

Bug Fixes

Terminal startup now properly initializes environment profiles from package managers
Tab rendering improved to maintain terminal history for all open tabs

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-26T07:07:40Z

Walkthrough

Terminal-manager now spawns shell processes as login shells by computing platform-specific arguments (zsh/bash use "-l") and passing them to pty.spawn. TabsContent refactors tab rendering to compute all workspace tabs within a memo, determine the active tab's display hierarchy, and render all workspace tabs while hiding non-active ones to preserve terminal scrollback.

Changes

Cohort / File(s)	Summary
Terminal login shell initialization `apps/desktop/src/main/lib/terminal-manager.ts`	Computes `shellArgs` based on shell type (zsh/bash get `["-l"]`, others get `[]`) and passes them to `pty.spawn` to ensure profile scripts initialize before shell rc files.
Tab rendering and workspace state `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/index.tsx`	Refactors `tabToRender` computation to collect all workspace tabs, handle tab hierarchy (parent/child relationships), determine active tab display state, and render all workspace tabs as hidden components (except active) to preserve terminal scrollback. Updates drop overlay scoping to active tab only.

Sequence Diagram(s)

sequenceDiagram
    participant Spawner as Terminal Spawner
    participant PTY as pty.spawn
    participant Shell as Shell Process
    
    rect rgb(200, 220, 255)
    note over Spawner,Shell: New Login Shell Flow
    Spawner->>Spawner: Detect shell type (zsh/bash/other)
    Spawner->>Spawner: Compute shellArgs (["-l"] or [])
    Spawner->>PTY: spawn(shell, shellArgs, options)
    PTY->>Shell: Execute shell with args
    Shell->>Shell: Load profile scripts (pyenv, nvm, etc.)
    Shell->>Shell: Load rc files
    end

sequenceDiagram
    participant Render as TabsContent Render
    participant Memo as useMemo
    participant Logic as Tab Logic
    participant DOM as DOM Render
    
    rect rgb(220, 240, 220)
    note over Render,DOM: New Tab Rendering Flow
    Render->>Memo: Compute tabToRender + workspaceTabs
    Memo->>Logic: Collect all workspace tabs for active workspace
    Logic->>Logic: Find active tab, resolve parent hierarchy
    Logic->>Memo: Return {tabToRender, workspaceTabs}
    Memo->>DOM: Render active tab (visible)
    Memo->>DOM: Render hidden workspace tabs (preserve scrollback)
    DOM->>DOM: Apply drop overlay only to active tab
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

TabsContent refactoring requires careful verification of tab hierarchy resolution, null-handling edge cases (no activeWorkspaceId, no activeTabId, parent lookup), and confirmation that hidden tab rendering preserves scrollback without performance degradation.
Drop overlay scoping needs validation that conditional drop zone logic correctly isolates to the active tab only.
Terminal shell args addition is straightforward but verify shellArgs logic handles all shell types correctly and passes arguments in the expected format to pty.spawn.

Possibly related PRs

PR #120: Rewrites TerminalManager.createOrAttach to be async and add history/wasRecovered, directly overlaps with this PR's modifications to the same terminal spawning function.
PR #106: Refactors TabsContent UI/drag-drop/DropOverlay logic, touching the same rendering component and drop zone behavior.
PR #105: Modifies the same file (TabsContent/index.tsx) and changes tab rendering logic, directly related at code level.

Poem

🐰 A shell springs forth in login attire,
Profile scripts load, as dreams inspire,
Tabs hidden beneath, their scrollback preserved,
The active one gleams—each interaction served!
~CodeRabbit 🌿

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, leaving all required sections from the template (Description, Related Issues, Type of Change, Testing, Screenshots, Additional Notes) completely empty.	Add a comprehensive description following the repository template, including what changes were made, related issues, the type of change, testing performed, and any additional context.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'keep terminal tabs rendered' is specific and directly related to the main change in the TabsContent component, which replaces single-tab rendering with multi-tab rendering to preserve terminal scrollback behavior.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch pearl-mountain-56

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b8473d and 26bd1db.

📒 Files selected for processing (2)

apps/desktop/src/main/lib/terminal-manager.ts (1 hunks)
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/index.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (7)

**/*.{ts,tsx,js,jsx,json}