Skip to content

feat(ui): add cursor-pointer to all clickable elements #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samuelswandi wants to merge 8 commits into from
Closed

feat(ui): add cursor-pointer to all clickable elements #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e9f75f
feat(ui): add cursor-pointer to sidebar header buttons
samuelswandi Jan 31, 2026
f4dcf6a
feat(ui): add cursor-pointer to new workspace button
samuelswandi Jan 31, 2026
bcaaf66
feat(ui): add cursor-pointer to project header buttons
samuelswandi Jan 31, 2026
2ab5218
feat(ui): add cursor-pointer to workspace list item buttons
samuelswandi Jan 31, 2026
778d3d7
feat(ui): add cursor-pointer to branch switcher button
samuelswandi Jan 31, 2026
a796861
feat(ui): add cursor-pointer to settings button
samuelswandi Jan 31, 2026
61e1e30
feat(ui): add cursor-pointer to open in button
samuelswandi Jan 31, 2026
aaa7eeb
feat(ui): add cursor-pointer to open in menu button
samuelswandi Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions apps/desktop/src/renderer/components/OpenInButton/OpenInButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,13 @@ export function OpenInButton({
{label && (
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="outline"
size="sm"
className="gap-1.5"
onClick={handleOpenLastUsed}
disabled={!path}
>
<Button
variant="outline"
size="sm"
className="gap-1.5 cursor-pointer"
onClick={handleOpenLastUsed}
disabled={!path}
>
<img
src={currentApp.icon}
alt=""
Expand All @@ -180,7 +180,7 @@ export function OpenInButton({
<Button
variant="outline"
size="sm"
className="gap-1"
className="gap-1 cursor-pointer"
disabled={!path}
>
<span>Open</span>
Expand Down
2 changes: 2 additions & 0 deletions ...thenticated/_dashboard/components/TopBar/components/OpenInMenuButton/OpenInMenuButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
"hover:bg-secondary hover:border-border",
"focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring",
"active:scale-[0.98]",
"cursor-pointer",
isLoading && "opacity-50 pointer-events-none",
)}
>
Expand Down Expand Up @@ -137,6 +138,7 @@ export const OpenInMenuButton = memo(function OpenInMenuButton({
"hover:bg-secondary hover:border-border hover:text-foreground",
"focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring",
"active:scale-[0.98]",
"cursor-pointer",
isLoading && "opacity-50 pointer-events-none",
)}
>
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/renderer/screens/main/components/SettingsButton/SettingsButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function SettingsButton() {
size="icon"
onClick={() => navigate({ to: "/settings/account" })}
aria-label="Open settings"
className="no-drag"
className="no-drag cursor-pointer"
>
<CiSettings className="size-5" />
</Button>
Expand Down
6 changes: 3 additions & 3 deletions ...op/src/renderer/screens/main/components/WorkspaceSidebar/ProjectSection/ProjectHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export function ProjectHeader({
onClick={onToggleCollapse}
className={cn(
"flex items-center justify-center size-8 rounded-md",
"hover:bg-muted/50 transition-colors",
"hover:bg-muted/50 transition-colors cursor-pointer",
)}
>
<ProjectThumbnail
Expand Down Expand Up @@ -309,7 +309,7 @@ export function ProjectHeader({
onNewWorkspace();
}}
onContextMenu={(e) => e.stopPropagation()}
className="p-1 rounded hover:bg-muted transition-colors shrink-0 ml-1"
className="p-1 rounded hover:bg-muted transition-colors shrink-0 ml-1 cursor-pointer"
>
<HiMiniPlus className="size-4 text-muted-foreground" />
</button>
Expand All @@ -325,7 +325,7 @@ export function ProjectHeader({
onClick={onToggleCollapse}
onContextMenu={(e) => e.stopPropagation()}
aria-expanded={!isCollapsed}
className="p-1 rounded hover:bg-muted transition-colors shrink-0 ml-1"
className="p-1 rounded hover:bg-muted transition-colors shrink-0 ml-1 cursor-pointer"
>
<HiChevronRight
className={cn(
Expand Down
20 changes: 10 additions & 10 deletions ...renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export function WorkspaceListItem({
onMouseEnter={handleMouseEnter}
className={cn(
"relative flex items-center justify-center size-8 rounded-md",
"hover:bg-muted/50 transition-colors",
"hover:bg-muted/50 transition-colors cursor-pointer",
isActive && "bg-muted",
)}
>
Expand Down Expand Up @@ -492,15 +492,15 @@ export function WorkspaceListItem({
) : (
<Tooltip delayDuration={300}>
<TooltipTrigger asChild>
<button
type="button"
onClick={(e) => {
e.stopPropagation();
handleDeleteClick();
}}
className="opacity-0 group-hover:opacity-100 transition-opacity flex items-center justify-center text-muted-foreground hover:text-foreground"
aria-label="Close workspace"
>
<button
type="button"
onClick={(e) => {
e.stopPropagation();
handleDeleteClick();
}}
className="opacity-0 group-hover:opacity-100 transition-opacity flex items-center justify-center text-muted-foreground hover:text-foreground cursor-pointer"
aria-label="Close workspace"
>
<HiMiniXMark className="size-3.5" />
</button>
</TooltipTrigger>
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/WorkspaceSidebar/WorkspaceListItem/components/BranchSwitcher/BranchSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function BranchSwitcher({
<button
type="button"
className={cn(
"flex items-center gap-0.5 px-1 py-0.5 rounded text-xs text-muted-foreground hover:text-foreground hover:bg-muted/50 transition-colors",
"flex items-center gap-0.5 px-1 py-0.5 rounded text-xs text-muted-foreground hover:text-foreground hover:bg-muted/50 transition-colors cursor-pointer",
isOpen && "bg-muted/50 text-foreground",
className,
)}
Expand Down
4 changes: 2 additions & 2 deletions ...er/screens/main/components/WorkspaceSidebar/WorkspaceSidebarHeader/NewWorkspaceButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function NewWorkspaceButton({
<button
type="button"
onClick={handleClick}
className="group flex items-center justify-center size-8 rounded-md hover:bg-accent/50 transition-colors"
className="group flex items-center justify-center size-8 rounded-md hover:bg-accent/50 transition-colors cursor-pointer"
>
<div className="flex items-center justify-center size-5 rounded bg-accent">
<LuPlus className="size-3" strokeWidth={STROKE_WIDTH_THICK} />
Expand All @@ -69,7 +69,7 @@ export function NewWorkspaceButton({
<button
type="button"
onClick={handleClick}
className="group flex items-center gap-2 px-2 py-1.5 w-full text-sm font-medium text-muted-foreground hover:text-foreground hover:bg-accent/50 rounded-md transition-colors"
className="group flex items-center gap-2 px-2 py-1.5 w-full text-sm font-medium text-muted-foreground hover:text-foreground hover:bg-accent/50 rounded-md transition-colors cursor-pointer"
>
<div className="flex items-center justify-center size-5 rounded bg-accent">
<LuPlus className="size-3" strokeWidth={STROKE_WIDTH_THICK} />
Expand Down
58 changes: 29 additions & 29 deletions ...creens/main/components/WorkspaceSidebar/WorkspaceSidebarHeader/WorkspaceSidebarHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,39 +45,39 @@ export function WorkspaceSidebarHeader({
<div className="flex flex-col items-center border-b border-border py-2 gap-2">
<Tooltip delayDuration={300}>
<TooltipTrigger asChild>
<button
type="button"
onClick={handleWorkspacesClick}
className={cn(
"flex items-center justify-center size-8 rounded-md transition-colors",
isWorkspacesListOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
)}
>
<LuLayers className="size-4" strokeWidth={STROKE_WIDTH} />
</button>
<button
type="button"
onClick={handleWorkspacesClick}
className={cn(
"flex items-center justify-center size-8 rounded-md transition-colors cursor-pointer",
isWorkspacesListOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
)}
>
<LuLayers className="size-4" strokeWidth={STROKE_WIDTH} />
</button>
</TooltipTrigger>
<TooltipContent side="right">Workspaces</TooltipContent>
</Tooltip>

<Tooltip delayDuration={300}>
<TooltipTrigger asChild>
<button
type="button"
onClick={handleTasksClick}
className={cn(
"flex items-center justify-center size-8 rounded-md transition-colors",
isTasksOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
)}
>
<HiOutlineClipboardDocumentList
className="size-4"
strokeWidth={STROKE_WIDTH}
/>
</button>
<button
type="button"
onClick={handleTasksClick}
className={cn(
"flex items-center justify-center size-8 rounded-md transition-colors cursor-pointer",
isTasksOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
)}
>
<HiOutlineClipboardDocumentList
className="size-4"
strokeWidth={STROKE_WIDTH}
/>
</button>
</TooltipTrigger>
<TooltipContent side="right">Tasks</TooltipContent>
</Tooltip>
Expand All @@ -93,7 +93,7 @@ export function WorkspaceSidebarHeader({
type="button"
onClick={handleWorkspacesClick}
className={cn(
"flex items-center gap-2 px-2 py-1.5 w-full rounded-md transition-colors",
"flex items-center gap-2 px-2 py-1.5 w-full rounded-md transition-colors cursor-pointer",
isWorkspacesListOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
Expand All @@ -109,7 +109,7 @@ export function WorkspaceSidebarHeader({
type="button"
onClick={handleTasksClick}
className={cn(
"flex items-center gap-2 px-2 py-1.5 w-full rounded-md transition-colors",
"flex items-center gap-2 px-2 py-1.5 w-full rounded-md transition-colors cursor-pointer",
isTasksOpen
? "text-foreground bg-accent"
: "text-muted-foreground hover:text-foreground hover:bg-accent/50",
Expand Down