Skip to content

Project icons are missing in 1.16 #5843

Closed

Description

@aaronvarga

Where did this happen?

Desktop app (macOS)

Version

1.16.0

What happened?

I no longer have the ability to select an icon for each project. I have 15-20 active projects at once and icons are a super helpful visual cue so I know which one to click.

Steps to reproduce

Add a project, go to project settings. Nowhere to set the icon.

Logs, screenshots, or recordings

No response

Activity

  1. added a commit that references this issue on Jul 21, 2026
    90c994c
  2. de1mat commented on Jul 27, 2026

    @de1mat
    Contributor

    Seeing this too, and the cause looks unintentional.

    The icon picker was removed by #5731 (637aa9ec7, "local-first projects"), which shipped in v1.16.0. In v2, custom icons were stored in the cloud v2Projects.icon_url column. That PR moved project ownership into the local host.db, but icon_url didn't get a column in the new local schema, so V2ProjectSettings swapped the editable field for a read-only thumbnail:

    - <IconUploadField iconUrl={project.iconUrl ?? null} ... />
    + const iconUrl = project.repoOwner ? `https://github.com/${project.repoOwner}.png?size=64` : null
    + <ProjectThumbnail projectName={project.name} iconUrl={iconUrl} />

    Nothing in #5731's description mentions icons, so this reads like fallout from the cloud-to-local move rather than a deliberate removal.

    Worth adding that the sidebar is affected the same way: V2WorkspaceProjectIcon has no iconUrl prop at all and derives purely from githubOwner, so every project under the same GitHub owner renders an identical avatar. With 15-20 projects open, as you describe, that's the part that really bites.

    There's already a fix in #5845 ("make v2 project icons local-first"), which adds the icon_url column to host.db and restores the picker. It's been open since 21 July without a reviewer. I cherry-picked both commits onto current main locally to check they still apply:

    • one conflict, in packages/trpc/src/router/v2-project/v2-project.test.ts, which main deleted independently in c36fa952f, so resolving it as a delete is straightforward
    • the new host-service migration lands as 0012 and main is still on 0011, so no renumbering needed
    • lint clean, tests pass (the restored picker test, plus 9 host-service project integration tests)
    • typecheck shows the same 10 pre-existing CodeMirror version errors as main, none related

    Happy to open a rebased PR if that's useful, or leave it if #5845 just needs a reviewer. Whichever avoids duplicated effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions