Added Unix Domain Socket support.#991
Conversation
|
This is a pretty clear API breakage (not to mention the fact it requires us to expose internal implementation details to plugins), and while it's been planned for the next major revision of Velocity, it's not been a high priority for a few reasons (mainly due to lack of time on my part). |
|
I think it shouldn't break the api. In the only class in the api that i modified, i only added methods or modified private fields and added constructors, but removed or modified no existing components (except for the "ServerInfo" constructor to use the SocketAddress type as parameter and not the InetSocketAddress type, which shouldn't break something, because the type InetSocketAddress extends from it) |
|
Modifying the existing 2-ary constructor of In addition, |
|
Yes i could add a third constructor with this type and for the |
d92c244 to
025f779
Compare
There was a problem hiding this comment.
I don't see how to avoid the getAddress breakage sensibly. We will have to wait a bit, iirc I've seen some talks about a near-future major release launch in Discord.
I would prefer to see the commit mentioned in the other comment backported, since astei already tested those changes (the address parsing portion of this PR is a perfect candidate for some unit tests).
|
Now i removed the |
Closes #991. We can't properly support this without an API break, so let's just do it in 5.0.0.
It adds Unix Domain Socket support, so that it don't require a tcp port to be binded to work.