Skip to content

full support for UnixDomainSocket#10088

Closed
Coloryr wants to merge 1 commit into
PaperMC:masterfrom
Coloryr:full-unix
Closed

full support for UnixDomainSocket#10088
Coloryr wants to merge 1 commit into
PaperMC:masterfrom
Coloryr:full-unix

Conversation

@Coloryr

@Coloryr Coloryr commented Dec 28, 2023

Copy link
Copy Markdown

full support for UnixDomainSocketAddress
It must work with this
It change the api, but retained original support
{4E839E59-23CF-4fa3-B0F9-2C75F679304E}
image

server-ip=unix\:/tmp/paperserver.sock
[servers]
# Configure your servers here. Each key represents the server's name, and the value
# represents the IP address of the server to connect to.
lobby = "unix:/tmp/paperserver.sock"

@electronicboy

Copy link
Copy Markdown
Member

except it doesn't retain original support, it just means that that stuff will blow up, and so, this cannot be merged until a major

also, patches generally should not modify earlier patches

@Owen1212055

Copy link
Copy Markdown
Member

Seems to dupe ? #9086

@Coloryr

Coloryr commented Dec 29, 2023

Copy link
Copy Markdown
Author

except it doesn't retain original support, it just means that that stuff will blow up, and so, this cannot be merged until a major

also, patches generally should not modify earlier patches

No, if UDS is not used, the original API is supported
And I need to delete the patch before the modification?

@Coloryr

Coloryr commented Dec 29, 2023

Copy link
Copy Markdown
Author

Seems to dupe ? #9086

The modified content is the same, but the modification method and API processing are different

@Coloryr Coloryr changed the title full support for UnixDomainSocketAddress full support for UnixDomainSocket Dec 29, 2023
@Coloryr

Coloryr commented Dec 29, 2023

Copy link
Copy Markdown
Author

My modification is for the group server
and the idea is backend server use UDS transport

@Coloryr Coloryr closed this Dec 29, 2023
@Coloryr Coloryr deleted the full-unix branch December 29, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants