Skip to content

[0-size Tensor No.132、236、240、241、259] Add 0-size Tensor support for masked_select - #73180

Merged
wanghuancoder merged 5 commits into
PaddlePaddle:developfrom
co63oc:e4
Jun 16, 2025
Merged

wanghuancoder merged 5 commits into
PaddlePaddle:developfrom
co63oc:e4

Conversation

@co63oc

@co63oc co63oc commented Jun 9, 2025 •

Copy link
Copy Markdown
Contributor

PR Category

Execute Infrastructure

PR Types

Improvements

Description

132 paddle.masked_select
236 paddle.nn.utils.parameters_to_vector
240 paddle.pdist
241 paddle.polar
259 paddle.sinc

增加单测

paddle.masked_select, paddle.polar 在 report/0size_tensor_gpu/test_history/20250528/accuracy/error_config.txt 中没有配置,应该是没有错误
image

paddle.nn.utils.parameter_to_vector 是PaddleAPITest错误,没有其他错误
image

paddle.pdist GPU/CPU测试都通过
paddle.sinc GPU/CPU测试都通过

@paddle-bot

paddle-bot Bot commented Jun 9, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Jun 9, 2025
@co63oc co63oc changed the title [0-size Tensor No.132、165、231、236、240] Add 0-size Tensor support for masked_select [0-size Tensor No.132、165、231、236、240、241、259] Add 0-size Tensor support for masked_select Jun 9, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jun 9, 2025
@DanielSun11

Copy link
Copy Markdown
Contributor

CPU上测试都过了吗?

@co63oc co63oc changed the title [0-size Tensor No.132、165、231、236、240、241、259] Add 0-size Tensor support for masked_select [0-size Tensor No.132、236、240、241、259] Add 0-size Tensor support for masked_select Jun 11, 2025
@co63oc

co63oc commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

CPU上测试都过了吗?

已复测更新了描述

@DanielSun11

Copy link
Copy Markdown
Contributor

@co63oc

co63oc commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

https://github.com/PFCCLab/PaddleAPITest/blame/main/report/0size_tensor_gpu/error_config.txt 中有paddle.masked_select的0-size 配置https://github.com/PFCCLab/PaddleAPITest/blob/main/report/0size_tensor_gpu/error_config_paddleonly.txt#L6571有 paddle.polar的0-size 配置,请验证一下

masked_select
GPU 测试通过
image
CPU 测试通过
image

polar
GPU测试通过
image
CPU 测试通过
image

@ooooo-create ooooo-create left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面这个算 0 size 问题吗,cpu 和 GPU 的梯度不一样了,torch 是[0,0].paddle 的cpu是对的

import paddle
import numpy as np
# paddle.device.set_device('cpu')
x = paddle.to_tensor([1,2], dtype='float32')
x.stop_gradient = False
y = paddle.to_tensor([False,False], dtype='bool')
z = x.masked_select(y)
print(z) #shape=[0]
z.sum().backward()
print(x.grad)

@DanielSun11

Copy link
Copy Markdown
Contributor

下面这个算 0 size 问题吗,cpu 和 GPU 的梯度不一样了,torch 是[0,0].paddle 的cpu是对的

import paddle
import numpy as np
# paddle.device.set_device('cpu')
x = paddle.to_tensor([1,2], dtype='float32')
x.stop_gradient = False
y = paddle.to_tensor([False,False], dtype='bool')
z = x.masked_select(y)
print(z) #shape=[0]
z.sum().backward()
print(x.grad)

算是0-size问题。因为masked_select_grad的输入为0-size Tensor。PaddleAPITest可能还不支持masked_select_grad的检查,导致没测出异常。请 @co63oc 看一下

@co63oc

co63oc commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

下面这个算 0 size 问题吗,cpu 和 GPU 的梯度不一样了,torch 是[0,0].paddle 的cpu是对的

import paddle
import numpy as np
# paddle.device.set_device('cpu')
x = paddle.to_tensor([1,2], dtype='float32')
x.stop_gradient = False
y = paddle.to_tensor([False,False], dtype='bool')
z = x.masked_select(y)
print(z) #shape=[0]
z.sum().backward()
print(x.grad)

算是0-size问题。因为masked_select_grad的输入为0-size Tensor。PaddleAPITest可能还不支持masked_select_grad的检查,导致没测出异常。请 @co63oc 看一下

已修改kernel,增加单测

@co63oc

co63oc commented Jun 13, 2025

Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@DanielSun11 DanielSun11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants