Skip to content

[Accuracy diff No.57、69] Fix accuracy diff for sum API - #73012

Merged
lshpku merged 1 commit into
PaddlePaddle:developfrom
ooooo-create:accuracy_sum
May 30, 2025
Merged

lshpku merged 1 commit into
PaddlePaddle:developfrom
ooooo-create:accuracy_sum

Conversation

@ooooo-create

@ooooo-create ooooo-create commented May 29, 2025 •

Copy link
Copy Markdown
Collaborator

PR Category

Execute Infrastructure

PR Types

Improvements

Description

https://github.com/pytorch/pytorch/blob/3c74a72ea08a7a7e50c586c22eb6d75e6fed54f3/aten/src/ATen/native/cpu/SumKernel.cpp#L625C1-L629C2

Torch 为了精度float16和bfloat16也是会进行 float32 的计算,为了精度采用 pytorch 的处理方式,进行计算时也采用 float32,比 cast的优先级高
PaddleAPTTest 测试通过
图片

@paddle-bot

paddle-bot Bot commented May 29, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label May 29, 2025
@ooooo-create ooooo-create changed the title sum [Accuracy diff No.57、69] Fix accuracy diff for sum API May 29, 2025
@codecov-commenter

codecov-commenter commented May 29, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@e1184db). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/cpu/reduce_sum_kernel.cc 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #73012   +/-   ##
==========================================
  Coverage           ?   92.30%           
==========================================
  Files              ?        1           
  Lines              ?       13           
  Branches           ?        0           
==========================================
  Hits               ?       12           
  Misses             ?        1           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lshpku
lshpku merged commit 9a0351c into PaddlePaddle:develop May 30, 2025
@ooooo-create
ooooo-create deleted the accuracy_sum branch September 29, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants