Skip to content

[0-size Tensor No.138] Add 0-size Tensor support for mv - #72929

Closed
co63oc wants to merge 11 commits into
PaddlePaddle:developfrom
co63oc:b25
Closed

co63oc wants to merge 11 commits into
PaddlePaddle:developfrom
co63oc:b25

Conversation

@co63oc

@co63oc co63oc commented May 26, 2025

Copy link
Copy Markdown
Contributor

PR Category

Execute Infrastructure

PR Types

Improvements

Description

mv 修改前向和反向
infermeta 不用修改
kernel 修改 cpu/gpu,前向共用impl实现

PaddleAPITest 测试已修复cuda error, paddle, error, 错误为torch error
image

@paddle-bot

paddle-bot Bot commented May 26, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label May 26, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label May 26, 2025
@codecov-commenter

codecov-commenter commented May 26, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@425c14d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/cpu/mv_grad_kernel.cc 0.00% 7 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #72929   +/-   ##
==========================================
  Coverage           ?    0.00%           
==========================================
  Files              ?        1           
  Lines              ?        7           
  Branches           ?        0           
==========================================
  Hits               ?        0           
  Misses             ?        7           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luotao1

luotao1 commented May 27, 2025

Copy link
Copy Markdown
Collaborator

@DanielSun11 可以review了

@DanielSun11 DanielSun11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要补充单测case。需要覆盖至少如下三种情况:

  • case1:|x:0-size | vec:非0-size |
  • case2:|x:非0-size | vec:0-size |
  • case3:|x:0-size | vec:0-size |

@co63oc

co63oc commented May 29, 2025 •

Copy link
Copy Markdown
Contributor Author

需要补充单测case。需要覆盖至少如下三种情况:

  • case1:|x:0-size | vec:非0-size |
  • case2:|x:非0-size | vec:0-size |
  • case3:|x:0-size | vec:0-size |

已修改, x末尾列需要和vec维度值相同,所以测试用例为
[0, 100], [100]
[100, 0], [0]
[0], [0]

前向增加判断 vec numel 为0,out可能不是0size,返回填充0

CI错误已修复

@co63oc

co63oc commented Jun 1, 2025

Copy link
Copy Markdown
Contributor Author

@co63oc co63oc closed this Jun 1, 2025
@co63oc
co63oc deleted the b25 branch June 14, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants