Repository navigation
[0-size Tensor No.101、311] Add 0-size Tensor support for lerp - #72906
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
co63oc
changed the title
Contributor
Author
|
|
DanielSun11
self-requested a review
May 25, 2025 15:04
DanielSun11
reviewed
May 25, 2025
DanielSun11
reviewed
May 25, 2025
DanielSun11
requested changes
May 26, 2025
| } else { | ||
| phi::Full<T, Context>( | ||
| ctx, phi::IntArray(common::vectorize(x_grad->dims())), 0, x_grad); | ||
| } |
Contributor
There was a problem hiding this comment.
逻辑感觉不太对。应该是：
if (x_grad) {
ctx.template Alloc<T>(x_grad);
if (x_grad->numel() != 0) {
phi::Full<T, Context>(
ctx, phi::IntArray(common::vectorize(x_grad->dims())), 0, x_grad);
}
}
非0 size 的Tensor需要先分配空间再初始化
Contributor
Author
There was a problem hiding this comment.
phi::Full 调用的是FullKernel，也有分配空间的代码
简化为 phi::Full，
phi::Full 调用FullKernel 已经有numel = 0的判断
Contributor
|
请merge下最新的develop分支 |
Collaborator
|
@DanielSun11 可以review了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
lerp修改前向和反向，去掉判断 numel 为0的异常信息
infermeta 不用修改
kernel 修改cpu/gpu
PaddleAPITest 测试paddle error和cuda error已通过，错误为torch error，torch没有支持0-size
