Repository navigation
[3.8] Remove unused dependency astor - #72870
Merged
Merged
Conversation
gouzil
requested review from
SigureMo,
jzhang533,
kolinwei,
phlrain and
zrr1999
as code owners
May 22, 2025 06:09
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
May 22, 2025
|
|
||
| >>> import scipy | ||
| >>> import astor | ||
| >>> import torch |
Collaborator
There was a problem hiding this comment.
这代码 CI 会跑的，import torch 是什么鬼？改用 decorator
SigureMo
changed the title
astor
SigureMo
changed the title
astorastor
SigureMo
reviewed
May 22, 2025
|
|
||
| [[tool.mypy.overrides]] | ||
| module = [ | ||
| "astor", |
Collaborator
There was a problem hiding this comment.
这里加上 decorator 吧，mypy 检查挂了
SigureMo
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Deprecations
Description
移除第三方库
astor，其仅用于 AST 动转静，但 AST 动转静很久之前就只在 3.9 及以上版本使用内置的ast.unparse替代astor了，而 python 3.8 已经退场，astor已经彻底无用，故彻底移除Related links