Skip to content

[SOT][3.8] Cleanup Python 3.8-specific bytecode implementations - #72855

Merged
SigureMo merged 1 commit into
PaddlePaddle:developfrom
cattidea:sot/cleanup-bytecode-implementation-unique-to-py38
May 22, 2025
Merged

SigureMo merged 1 commit into
PaddlePaddle:developfrom
cattidea:sot/cleanup-bytecode-implementation-unique-to-py38

Conversation

@SigureMo

Copy link
Copy Markdown
Collaborator

PR Category

Execute Infrastructure

PR Types

Deprecations

Description

Python 3.8 退场,清理 SOT 中 Python 3.8 独有字节码的实现,具体字节码参考 PaddlePaddle/PaddleSOT#118

@SigureMo
SigureMo requested review from Copilot and gouzil May 21, 2025 16:12
@paddle-bot

paddle-bot Bot commented May 21, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up Python 3.8–specific bytecode implementations by removing deprecated unpack functions and unused imports. Key changes include:

  • Removing the RangeVariable import and associated dependency.
  • Deleting build_seq_unpack and its related unpack methods.
  • Ensuring that Python 3.8–specific bytecode support is fully removed.
Comments suppressed due to low confidence (2)

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py:102

  • Double-check that the removal of RangeVariable does not leave any dangling references in other parts of the code that might still rely on it.
RangeVariable,

python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py:1227

  • Ensure that any remaining references to the removed unpack functions (build_seq_unpack and its wrappers) are updated or removed to prevent runtime errors.
def build_seq_unpack(self, instr: Instruction):

@SigureMo SigureMo changed the title [SOT][3.8] Cleanup bytecode implementations unique to Python 3.8 [SOT][3.8] Cleanup Python 3.8-specific bytecode implementations May 21, 2025
@SigureMo SigureMo mentioned this pull request May 21, 2025
12 of 21 tasks
@SigureMo
SigureMo merged commit 72279a9 into PaddlePaddle:develop May 22, 2025
@SigureMo
SigureMo deleted the sot/cleanup-bytecode-implementation-unique-to-py38 branch May 22, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants