Repository navigation
Conversation
|
你的PR提交成功,感谢你对开源项目的贡献! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up Python 3.8–specific bytecode implementations by removing deprecated unpack functions and unused imports. Key changes include:
- Removing the RangeVariable import and associated dependency.
- Deleting build_seq_unpack and its related unpack methods.
- Ensuring that Python 3.8–specific bytecode support is fully removed.
Comments suppressed due to low confidence (2)
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py:102
- Double-check that the removal of RangeVariable does not leave any dangling references in other parts of the code that might still rely on it.
RangeVariable,
python/paddle/jit/sot/opcode_translator/executor/opcode_executor.py:1227
- Ensure that any remaining references to the removed unpack functions (build_seq_unpack and its wrappers) are updated or removed to prevent runtime errors.
def build_seq_unpack(self, instr: Instruction):
gouzil
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Deprecations
Description
Python 3.8 退场,清理 SOT 中 Python 3.8 独有字节码的实现,具体字节码参考 PaddlePaddle/PaddleSOT#118