Repository navigation
[Accuracy diff No.181、182、183] fix maximum_grad minimum_grad bug - #71716
Merged
wanghuancoder merged 15 commits intoMar 20, 2025
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
wanghuancoder
requested review from
JiabinYang and
xiaoguoguo626807
as code owners
March 18, 2025 03:29
xiaoguoguo626807
approved these changes
Mar 20, 2025
luotao1
approved these changes
Mar 20, 2025
| // cast, because divide and add kernel is not support bf16 and fp16 on CPU | ||
| if (out_grad.dtype() == phi::DataType::BFLOAT16 || | ||
| out_grad.dtype() == phi::DataType::FLOAT16) { | ||
| out_grad_copy = cast<T>(out_grad, phi::DataType::FLOAT32); |
Contributor
There was a problem hiding this comment.
这个cast 有个统一的库函数，后面可以替换下
YqGe585
pushed a commit
to YqGe585/Paddle
that referenced
this pull request
May 7, 2025
* fix maximum_grad minimum_grad bug
wanghuancoder
changed the title
luotao1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
maximum_grad minimum_grad算法对齐Torch。
Pcard-67164