Skip to content

[CodeStyle][Typos][P-[1-10]] Fix typos(pacakage,Packge,payed,parellel,parm,Parm,PARM,Paramters,paramters,paremeter,parmeter,paramter,Paramater,paramete,parrent,parital,Partitial,partitial) - #70733

Merged
SigureMo merged 9 commits into
PaddlePaddle:developfrom
enkilee:typo-p1
Jan 20, 2025

Conversation

@enkilee

@enkilee enkilee commented Jan 9, 2025 •

Copy link
Copy Markdown
Collaborator

PR Category

User Experience

PR Types

Devs

Description

fixed:
pacakage,Packge,payed,parellel,parm,Parm,PARM,Paramters,paramters,paremeter,parmeter,paramter,Paramater,paramete,parrent,parital,Partitial,partitial

except:
padd: cause eigen used it:

Here is the definition of internal::padd from src/Core/arch/SSE/PacketMath.h:

template<> inline __m128  internal::padd(const __m128&  a, const __m128&  b) { return _mm_add_ps(a,b); }

Parm in [miopen.h],[miopen_helper.h] comment disabled.

cause miopenStatusBadParm used in third party openvino,mkldnn and onednn

@paddle-bot

paddle-bot Bot commented Jan 9, 2025

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Jan 9, 2025
Comment thread paddle/phi/backends/dynload/miopen.h Resolved
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 10, 2025
XieYunshen
XieYunshen previously approved these changes Jan 13, 2025
SigureMo
SigureMo previously approved these changes Jan 17, 2025

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo

Copy link
Copy Markdown
Collaborator

冲突了需要解决下 😂

@luotao1

luotao1 commented Jan 18, 2025

Copy link
Copy Markdown
Collaborator

冲突啦

@enkilee
enkilee dismissed stale reviews from SigureMo and XieYunshen via 95a58cd January 20, 2025 01:18
@SigureMo

Copy link
Copy Markdown
Collaborator

又冲突了

@SigureMo
SigureMo merged commit 117c0f6 into PaddlePaddle:develop Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants