Skip to content

[Typing][C-78] Add type annotations for python/paddle/incubate/nn/functional/masked_multihead_attention.py - #67558

Merged
luotao1 merged 6 commits into
PaddlePaddle:developfrom
HuaSakuLoop:my04
Aug 22, 2024
Merged

luotao1 merged 6 commits into
PaddlePaddle:developfrom
HuaSakuLoop:my04

Conversation

@HuaSakuLoop

Copy link
Copy Markdown
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/incubate/nn/functional/masked_multihead_attention.py

Related links

@SigureMo @megemini

@paddle-bot

paddle-bot Bot commented Aug 19, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Aug 19, 2024

@megemini megemini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档中的参数类型不对,也改一下吧:

cache_kvs (list(Tensor)|tuple(Tensor)): The cache structure tensors ...

改为

cache_kv (Tensor): The cache structure tensors ...

…n.py

Co-authored-by: megemini <megemini@outlook.com>

@megemini megemini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

@luotao1
luotao1 merged commit aaeef8d into PaddlePaddle:develop Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants