Repository navigation
[Infer Symbolic Shape No.166][BUAA] rms_norm - #67294
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
这里 coverage 没过的测试好像都不是我改的内容，麻烦帮忙看一下。 |
Contributor
timeout了，帮你rerun了 |
| // } | ||
| bool RmsNormOpInferSymbolicShape( | ||
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| const symbol::ShapeOrDataDimExprs &x_shape = |
Contributor
There was a problem hiding this comment.
命名不规范，x_shape_or_data
| pir::Operation *op, pir::InferSymbolicShapeContext *infer_context) { | ||
| const symbol::ShapeOrDataDimExprs &x_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); | ||
| std::vector<symbol::DimExpr> x_dims = x_shape.shape(); |
| const symbol::ShapeOrDataDimExprs &x_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); | ||
| std::vector<symbol::DimExpr> x_dims = x_shape.shape(); | ||
| size_t x_dims_size = x_dims.size(); |
|
|
||
| const auto &norm_weight_shape = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(3)); | ||
| const std::vector<symbol::DimExpr> norm_weight_dims = |
Contributor
There was a problem hiding this comment.
const std::vectorsymbol::DimExpr &，避免拷贝
Contributor
Author
收到 |
Contributor
|
LGTM |
luotao1
approved these changes
Aug 13, 2024
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
* Finished rms_norm op * Resolved suggested changes
33 of 35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加
rms_norm中等难度算子的符号推导接口实现，由于中等难度的算子对我而言难度比较大，所以这个算子我先单独提交的，已通过本地测试。