Repository navigation
[Typing][PEP585 Upgrade][BUAA][111-120] Use standard collections for type hints for 10 files in python/paddle/ - #67168
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
Contributor
Author
|
请问Generator的import时的位置该放在哪里 |
gouzil
reviewed
Aug 8, 2024
Comment on lines
+36
to
+38
| if TYPE_CHECKING: | ||
| from collections.abc import Sequence | ||
|
|
| from typing import TYPE_CHECKING, Literal, Sequence | ||
| from typing import TYPE_CHECKING, Literal | ||
|
|
||
| if TYPE_CHECKING: |
Collaborator
现在的位置就是对的 |
SigureMo
reviewed
Aug 9, 2024
| import random | ||
| import sys | ||
| import warnings | ||
| from collections.abc import Generator |
Collaborator
There was a problem hiding this comment.
这个在 type alias 里用了，不能改，运行时会挂
SigureMo
changed the title
python/paddle/
This was referenced Aug 9, 2024
Contributor
Author
|
PR-CI-SOT 还是过不了，报错： |
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…type hints for 10 files in `python/paddle/` (PaddlePaddle#67168) --------- Co-authored-by: gouzi <530971494@qq.com>
This was referenced Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
python/paddle/quantization/config.py
python/paddle/reader/decorator.py
python/paddle/sparse/nn/functional/conv.py
python/paddle/sparse/nn/layer/conv.py
python/paddle/sparse/unary.py
python/paddle/tensor/array.py
python/paddle/tensor/creation.py
python/paddle/tensor/einsum.py
python/paddle/tensor/linalg.py
python/paddle/tensor/manipulation.py