Skip to content

[Typing][PEP585 Upgrade][BUAA][101-110] Use standard collections for type hints for 10 files in python/paddle/ - #67165

Merged
SigureMo merged 6 commits into
PaddlePaddle:developfrom
Whsjrczr:typing1
Aug 9, 2024
Merged

SigureMo merged 6 commits into
PaddlePaddle:developfrom
Whsjrczr:typing1

Conversation

@Whsjrczr

@Whsjrczr Whsjrczr commented Aug 7, 2024 •

Copy link
Copy Markdown
Contributor

PR Category

User Experience

PR Types

Devs

Description

为如下10个文件添加 PEP 563,并进行 PEP 585 升级:
python/paddle/optimizer/lbfgs.py
python/paddle/optimizer/lr.py
python/paddle/optimizer/momentum.py
python/paddle/optimizer/nadam.py
python/paddle/optimizer/optimizer.py
python/paddle/optimizer/radam.py
python/paddle/optimizer/rmsprop.py
python/paddle/optimizer/rprop.py
python/paddle/optimizer/sgd.py
python/paddle/profiler/profiler.py

@paddle-bot

paddle-bot Bot commented Aug 7, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 8, 2024
Comment thread python/paddle/optimizer/rmsprop.py Outdated
Comment on lines +20 to +21
if TYPE_CHECKING:
from collections.abc import Sequence

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31 行不是有了么?放到 31 行那里

Comment thread python/paddle/optimizer/rprop.py Outdated
Comment on lines +20 to +21
if TYPE_CHECKING:
from collections.abc import Sequence

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的都有问题,直接参考 #66968 (comment) 进行修改

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到,已更新

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants