Repository navigation
[Infer Symbolic Shape No.27][BUAA]edit_distance - #67117
Merged
luotao1 merged 17 commits intoAug 12, 2024
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
gongshaotian
reviewed
Aug 7, 2024
|
|
||
| infer_context->AddEqualCstr(hypslength_shape_or_data.shape()[0], | ||
| hyps_dims[0]); | ||
|
|
Contributor
There was a problem hiding this comment.
这个分支里这四个值的0维都是相等的，是不是少了一个约束
Contributor
Author
There was a problem hiding this comment.
我再添加一个 infer_context->AddEqualCstr(hypslength_shape_or_data, refslength_shape_or_data); 吗?
luotao1
added
contributor
Contributor
Author
|
这个 Coverage 的测试本地好像测不出来问题，请问后续应该如何修改呢？ |
Contributor
|
test/legacy_test/test_edit_distance_op.py 中 check_pir flag为默认关闭状态，申请approve coverage流水线 |
gongshaotian
reviewed
Aug 8, 2024
| } | ||
|
|
||
| infer_context->SetShapeOrDataForValue(op->result(0), refs_shape_or_data); | ||
| symbol::ShapeOrData<symbol::DimExpr> single_dim_expr({symbol::DimExpr(1)}); |
Contributor
There was a problem hiding this comment.
symbol::ShapeOrDataDimExprs{symbol::TensorShapeOrDataDimExprs(
std::vectorsymbol::DimExpr{DimExpr(1)})} 这地方这么写吧
Contributor
Author
There was a problem hiding this comment.
这里给出的命令有一点小问题，我做了适当变化。
gongshaotian
approved these changes
Aug 8, 2024
35 of 38 tasks
zyfncg
reviewed
Aug 9, 2024
Comment on lines
+828
to
+832
| symbol::DimExpr hyps_dim = symbol::DimExpr(hyps_dims[1]); | ||
| symbol::DimExpr refs_dim = symbol::DimExpr(refs_dims[1]); | ||
|
|
||
| infer_context->AddEqualCstr(hyps_dim, one); | ||
| infer_context->AddEqualCstr(refs_dim, one); |
Collaborator
There was a problem hiding this comment.
AddEqualCstr 里的 hyps_dim 可以直接用 hyps_dims[1] 吧？
| infer_context->AddEqualCstr(refs_dim, one); | ||
| } | ||
|
|
||
| infer_context->SetShapeOrDataForValue(op->result(0), refs_shape_or_data); |
Collaborator
There was a problem hiding this comment.
这样有可能把data也传入，建议再确认下
Hongqing-work
approved these changes
Aug 12, 2024
Comment on lines
+832
to
+836
| symbol::ShapeOrDataDimExprs refs_shape_or_data_exprs( | ||
| symbol::TensorShapeOrDataDimExprs( | ||
| std::vector<symbol::DimExpr>{refs_dims})); | ||
| infer_context->SetShapeOrDataForValue(op->result(0), | ||
| refs_shape_or_data_exprs); |
Collaborator
There was a problem hiding this comment.
这里命名最好用out_shape_or_data_exprs，out和refs的shape相同，你这里的操作相当于是把refs的shape区取出来给out的符号表达初始化，可以下一个PR顺带修改下
luotao1
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Finished kldiv loss op * Finished kldiv loss op * Fixed name issues * Resolved comments in #67117
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
* Fixd edit_distance op * Added one more constraint * Added one more constraint * Resolved suggested changes * Added symbol:: before DimExpr * Fixed errors * Removed two unnecessary variables and added .shape() * Fixed typos * Revert to a previous version * added .shape() * added .shape * added .shape() * Try to resolve type conflicts * Try to resolve type conflicts * Try to resolve type conflicts * Try to resolve type conflicts
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…Paddle#67327) * Finished kldiv loss op * Finished kldiv loss op * Fixed name issues * Resolved comments in PaddlePaddle#67117
33 of 35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
修改了
edit_distance算子。因为我刚开始做 CINN，对于相关的内容还不太熟悉，所以这个我先单独提交的。此前给出的修改意见在 #66870 中，我针对修改意见做了修改。