Skip to content

[Typing][PEP585 Upgrade][BUAA][151-160] Use standard collections for type hints for 10 uts in test/ir/inference/ - #67015

Merged
luotao1 merged 2 commits into
PaddlePaddle:developfrom
BHmingyang:typing805_1
Aug 7, 2024
Merged

luotao1 merged 2 commits into
PaddlePaddle:developfrom
BHmingyang:typing805_1

Conversation

@BHmingyang

@BHmingyang BHmingyang commented Aug 5, 2024 •

Copy link
Copy Markdown
Contributor

PR Category

User Experience

PR Types

Devs

Description

为如下文件添加 PEP 563,并进行 PEP 585 升级:
test/ir/inference/test_trt_convert_bitwise_or.py
test/ir/inference/test_trt_convert_bmm.py
test/ir/inference/test_trt_convert_cast.py
test/ir/inference/test_trt_convert_clip.py
test/ir/inference/test_trt_convert_compare_and_logical.py
test/ir/inference/test_trt_convert_concat.py
test/ir/inference/test_trt_convert_conv2d.py
test/ir/inference/test_trt_convert_conv2d_transpose.py
test/ir/inference/test_trt_convert_conv3d_transpose.py
test/ir/inference/test_trt_convert_cross_multihead_matmul.py

Related links

#66936
@gouzil

@paddle-bot

paddle-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@BHmingyang BHmingyang changed the title [Typing][PEP585 Upgrade [BUAA]][No.151-No.160]Use stardand collections for type hints in some py files [BUAA][Typing][PEP585 Upgrade][No.151-No.160]Use stardand collections for type hints in some py files Aug 5, 2024
@SigureMo SigureMo added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Aug 5, 2024

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

求求了,看看任务描述好不?知道为啥让你们先提一个 PR 吗?这是自信能一次改好吗?先看看 #66975 把自己 PR 里相同的问题修一下吧,其他 PR 先别动,等这个 PR approve 了再说

PR 标题也不按规范来,模板里也不带 tracking issue……

别急别急别急,求求了~~~

@paddle-bot paddle-bot Bot added the contributor External developers label Aug 5, 2024
@BHmingyang BHmingyang changed the title [BUAA][Typing][PEP585 Upgrade][No.151-No.160]Use stardand collections for type hints in some py files [Typing][PEP585 Upgrade][BUAA][151-160]Use stardand collections for type hints in some py files Aug 6, 2024
@BHmingyang

Copy link
Copy Markdown
Contributor Author

收到,我改一下

@SigureMo SigureMo changed the title [Typing][PEP585 Upgrade][BUAA][151-160]Use stardand collections for type hints in some py files [Typing][PEP585 Upgrade][BUAA][151-160] Use stardand collections for type hints for 10 uts in test/ir/inference/ Aug 6, 2024
@BHmingyang

Copy link
Copy Markdown
Contributor Author
截屏2024-08-06 10 03 39

主要是这个问题是吧?

@SigureMo

SigureMo commented Aug 6, 2024

Copy link
Copy Markdown
Collaborator

主要是这个问题是吧?

是

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@luotao1 luotao1 self-assigned this Aug 6, 2024
@SigureMo SigureMo changed the title [Typing][PEP585 Upgrade][BUAA][151-160] Use stardand collections for type hints for 10 uts in test/ir/inference/ [Typing][PEP585 Upgrade][BUAA][151-160] Use standard collections for type hints for 10 uts in test/ir/inference/ Aug 6, 2024
@luotao1
luotao1 merged commit 366bee3 into PaddlePaddle:develop Aug 7, 2024
@BHmingyang
BHmingyang deleted the typing805_1 branch August 7, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants