Skip to content

【Infer Symbolic Shape [BUAA] No.93 & 98 & 105 】sqrt & sqrt_sr & silu & view_dtype - #67008

Merged
luotao1 merged 2 commits into
PaddlePaddle:developfrom
BHmingyang:cinn805_1
Aug 7, 2024
Merged

【Infer Symbolic Shape [BUAA] No.93 & 98 & 105 】sqrt & sqrt_sr & silu & view_dtype#67008
luotao1 merged 2 commits into
PaddlePaddle:developfrom
BHmingyang:cinn805_1

Conversation

@BHmingyang

@BHmingyang BHmingyang commented Aug 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Category

CINN

PR Types

Others

Description

sqrt/silu/view_dtype三个op输入和输出维度一致
发现sqrt_sr扩展算子

@paddle-bot

paddle-bot Bot commented Aug 5, 2024

Copy link
Copy Markdown

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 labels Aug 5, 2024
@BHmingyang

BHmingyang commented Aug 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

没有在 test/legacy_test/目录和 test/deprecated/legacy_test目录下搜索到这三个op(sqrt & silu & view_dtype)的相关单测，是否要自己手动添加？这三个算子对应的InferMeta都属于UnchangedInferMeta，查看同类型的算子，比如swish，（https://github.com/PaddlePaddle/Paddle/pull/66729）
该pr也没有手动添加单测。请问是否需要添加？

@gongshaotian

gongshaotian commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

没有在 test/legacy_test/目录和 test/deprecated/legacy_test目录下搜索到这三个op(sqrt & silu & view_dtype)的相关单测，是否要自己手动添加？这三个算子对应的InferMeta都属于UnchangedInferMeta，查看同类型的算子，比如swish，（https://github.com/PaddlePaddle/Paddle/pull/66729） 该pr也没有手动添加单测。请问是否需要添加？

InferMeta的分类不完全可信，需要自己参考用户接口文档、单测、op实现判断是否是same类型，目前看这几个没问题

gongshaotian
gongshaotian reviewed Aug 6, 2024
View reviewed changes
Comment thread paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/same_operands_result.h
OP_DECLARE_INFER_SYMBOLIC_SHAPE(ViewDtype)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(Sqrt)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(Sqrt_)
OP_DECLARE_INFER_SYMBOLIC_SHAPE(SqrtSr)

@gongshaotian gongshaotian Aug 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表扬一下，发现了一个Sqrt的扩展算子，这个算子不在符号推导任务列表但是也是需要加推导接口的👍

@gongshaotian gongshaotian Aug 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦同学将该算子手动加入任务列表中，并认领，感谢

@BHmingyang BHmingyang Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@BHmingyang BHmingyang Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

gongshaotian
gongshaotian approved these changes Aug 7, 2024
View reviewed changes

@gongshaotian gongshaotian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 merged commit 66f17e7 into PaddlePaddle:develop Aug 7, 2024
@BHmingyang
BHmingyang deleted the cinn805_1 branch August 7, 2024 09:02
@BHmingyang BHmingyang mentioned this pull request Aug 9, 2024
Closed
35 of 38 tasks
@BHmingyang BHmingyang changed the title 【Infer Symbolic Shape [BUAA] No.93 & 98 & 105 】sqrt & silu & view_dtype 【Infer Symbolic Shape [BUAA] No.93 & 98 & 105 】sqrt & sqrt_sr & silu & view_dtype Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gongshaotian gongshaotian gongshaotian approved these changes
+1 more reviewer
@luotao1 luotao1 luotao1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@luotao1 luotao1

@gongshaotian gongshaotian

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BHmingyang @gongshaotian @luotao1