Skip to content

【Infer Symbolic Shape BUAA No.38】Add FakeChannelWiseQuantizeAbsMax operator support for CINN compiler - #66612

Merged
luotao1 merged 4 commits into
PaddlePaddle:developfrom
Jeff114514:q_abs_max
Aug 1, 2024
Merged

luotao1 merged 4 commits into
PaddlePaddle:developfrom
Jeff114514:q_abs_max

Conversation

@Jeff114514

@Jeff114514 Jeff114514 commented Jul 26, 2024 •

Copy link
Copy Markdown
Contributor

PR Category

CINN

PR Types

Others

Description

添加FakeChannelWiseQuantizeAbsMax算子的符号推导接口

@paddle-bot

paddle-bot Bot commented Jul 26, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Jul 26, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 26, 2024
@gongshaotian
gongshaotian self-requested a review July 29, 2024 06:39

@gongshaotian gongshaotian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR type 修改为 other,标题名称和PR描述太简陋

return true;
}

bool FakeChannelWiseQuantizeAbsMaxOpInferSymbolicShape(

@gongshaotian gongshaotian Jul 29, 2024 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看一下添加OpTest单测是否复杂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经存在TestFakeChannelWiseQuantizeAbsMaxOp(OpTest)但没有打开 check_pir 和 check_symbol_infer 两个flag,请问这个情况如何修改

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 不需要再修改单测了 2. 需要把PR标题修改为全英文

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已完成修改

@Jeff114514 Jeff114514 changed the title 【Infer Symbolic Shape BUAA No.38】FakeChannelWiseQuantizeAbsMax 【Infer Symbolic Shape BUAA No.38】为CINN编译器增加FakeChannelWiseQuantizeAbsMax算子推导 Jul 29, 2024
@Jeff114514 Jeff114514 changed the title 【Infer Symbolic Shape BUAA No.38】为CINN编译器增加FakeChannelWiseQuantizeAbsMax算子推导 【Infer Symbolic Shape BUAA No.38】Add FakeChannelWiseQuantizeAbsMax operator support for CINN compiler Jul 29, 2024
@Jeff114514
Jeff114514 requested a review from gongshaotian August 1, 2024 03:16

@gongshaotian gongshaotian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
luotao1 merged commit b16a774 into PaddlePaddle:develop Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants