Skip to content

【Fix PIR Unittest No.423 BUAA】Fix test in test_nn_functional_embedding_static - #66214

Merged
wanghuancoder merged 6 commits into
PaddlePaddle:developfrom
Marcusryz:test_nn_functional_embedding_static
Jul 22, 2024
Merged

wanghuancoder merged 6 commits into
PaddlePaddle:developfrom
Marcusryz:test_nn_functional_embedding_static

Conversation

@Marcusryz

@Marcusryz Marcusryz commented Jul 18, 2024 •

Copy link
Copy Markdown
Contributor

PR Category

Others

PR Types

Others

Description

修复单测使之适应 PIR。

issue:#63740

Pcard-67164

@paddle-bot

paddle-bot Bot commented Jul 18, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wanghuancoder wanghuancoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIR下有paddle.pir.core.create_parameter,你可以在单测了加一个新老静态图的讨论,PIR下使用paddle.pir.core.create_parameter。

@Marcusryz Marcusryz changed the title 【Fix PIR Unittest No.19】Deprecate test_nn_functional_embedding_static ut 【Fix PIR Unittest No.19】Fix test in test_nn_functional_embedding_static Jul 19, 2024
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 label Jul 19, 2024

@wanghuancoder wanghuancoder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder
wanghuancoder merged commit 105f245 into PaddlePaddle:develop Jul 22, 2024
@Marcusryz Marcusryz changed the title 【Fix PIR Unittest No.19】Fix test in test_nn_functional_embedding_static 【Fix PIR Unittest No.19 BUAA】Fix test in test_nn_functional_embedding_static Jul 22, 2024
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Jul 22, 2024
…ic (PaddlePaddle#66214)

* Fix some bugs in test_nn_functional_embedding_static.

* Fix more bugs.

* Update.
@Marcusryz Marcusryz changed the title 【Fix PIR Unittest No.19 BUAA】Fix test in test_nn_functional_embedding_static 【Fix PIR Unittest No.423 BUAA】Fix test in test_nn_functional_embedding_static Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants