Skip to content

【Fix PIR Unittest No.564-581】Fix some test case in PIR - #65034

Merged
wanghuancoder merged 18 commits into
PaddlePaddle:developfrom
wanghuancoder:fix_pir_distribution
Jun 19, 2024
Merged

wanghuancoder merged 18 commits into
PaddlePaddle:developfrom
wanghuancoder:fix_pir_distribution

Conversation

@wanghuancoder

@wanghuancoder wanghuancoder commented Jun 11, 2024 •

Copy link
Copy Markdown
Contributor

PR Category

Others

PR Types

Others

Description

修复distribution下单测:

  1. distribution框架代码里多处对静态图控制流的使用是错误的,已修复。
  2. distribution框架代码里多处没有支持PIR,已支持。
  3. 暴露了PIR的一个问题:forward only算子返回的Value,stop_gradient应该是True,但我们是False,已修复。
  4. 暴露了PIR的一个问题:单测中存在一种使用场景:build model -> run -> 补充 build model -> run,两次run都会向PIR里插入fetch,导致第二次run fetch的数据与run的需求不符。但老的静态图,是不会插入fetch的。这个问题暂时在单测端修复。后续考虑是否解决。

关联Issue:#63740

Pcard-67164

@paddle-bot

paddle-bot Bot commented Jun 11, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen previously approved these changes Jun 18, 2024
@wanghuancoder
wanghuancoder merged commit 894db41 into PaddlePaddle:develop Jun 19, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants