Repository navigation
Revert "[Prim] add reduce_as op for paddle" - #63756
Closed
Galaxy1458 wants to merge 1 commit into
Closed
Galaxy1458 wants to merge 1 commit into
Galaxy1458 wants to merge 1 commit into
Conversation
This reverts commit 38182e7.
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
approved these changes
Apr 22, 2024
qili93
reviewed
Apr 23, 2024
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/device_context.h" | ||
| #include "paddle/phi/kernels/funcs/common_shape.h" | ||
| #include "paddle/phi/kernels/funcs/reduce_functor.h" |
Collaborator
There was a problem hiding this comment.
应该是这里的kernel头文件引入 funcs下面的 common_shape.h 和 reduce_functor.h导致的，把这两个头文件移到kernel.cu文件里面，kernel.h的头文件都会通过extension.h对外暴露，尽量在kernel.h的头文件引入不必要的其他.h文件，放到kernel.cc或者kernel.cu里面去就不会影响了。
cyber-pioneer
approved these changes
Apr 23, 2024
cyber-pioneer
left a comment
cyber-pioneer
left a comment
Collaborator
There was a problem hiding this comment.
todo：后续第三方问题修复后，恢复被revert的pr
|
Sorry to inform you that 6a12a89's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #63064
此PR导致PaddleCustomDevice仓库编译失败，阻碍业务交付周期
失败内容如下