Skip to content

[cmake] update pybind11 v2.10.3 to v2.12.0 - #63741

Merged
gouzil merged 3 commits into
PaddlePaddle:developfrom
gouzil:update_pybind11_v2.12
Apr 23, 2024
Merged

gouzil merged 3 commits into
PaddlePaddle:developfrom
gouzil:update_pybind11_v2.12

Conversation

@gouzil

@gouzil gouzil commented Apr 22, 2024 •

Copy link
Copy Markdown
Collaborator

PR Category

Others

PR Types

Others

Description

为了解决在 #63694 遇到的不能使用 shared_ptr 的问题,升级的同时也会解决原来CUDA 12的问题(不再需要patch, pybind11 的修复PR#4893)

  • 删除 patch 测试问题是否重现(重现CI,单测为test_cpp_extension)
  • 升级至v2.12

@paddle-bot

paddle-bot Bot commented Apr 22, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Apr 22, 2024
@gouzil gouzil changed the title [WIP][cmake] update pybind11 to v2.12 [WIP][cmake] update pybind11 v2.10.3 to v2.12.0 Apr 22, 2024
@SigureMo SigureMo self-assigned this Apr 22, 2024
Comment thread cmake/external/pybind11.cmake Outdated

include_directories(${PYBIND_INCLUDE_DIR})

set(PYBIND_PATCH_COMMAND "")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行和 50 行是不是也可以删掉了?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title [WIP][cmake] update pybind11 v2.10.3 to v2.12.0 [cmake] update pybind11 v2.10.3 to v2.12.0 Apr 23, 2024
@gouzil

gouzil commented Apr 23, 2024 •

Copy link
Copy Markdown
Collaborator Author

升级前:
466681713798865_ pic
升级后:
466671713798856_ pic
__doc__没有改变

@sunzhongkai588 sunzhongkai588 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants